Prefix job workloads with job- #591
Conversation
k8s-ci-robot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
cncf-cla: yes
mimowo
force-pushed
the
prefix-job-workload
branch
2 times, most recently
from
ab179d5
to
fdbbced
Compare
mimowo
force-pushed
the
prefix-job-workload
branch
from
fdbbced
to
d3fa5e3
Compare
|
/assign @alculquicondor |
| package common | ||
|
|
||
| func GetNameForJob(jobName string) string { | ||
| return "job-" + jobName |
There was a problem hiding this comment.
This can produce a name that is too long to pass validation. And if we cut the last characters we could have collisions. I would suggest using generateName.
There was a problem hiding this comment.
I see, makes sense, then probably we can park it for now and only use generateName for other frameworks, at least for now. WDYT?
Meaning we stay with the current workload naming for batch.Job.
|
/close |
|
@mimowo: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a preparatory task for #578. It is needed for avoiding workload name collisions created by different frameworks. The idea is that every framework will use a prefix for the workload name. The prefix for job will be "job-".
Which issue(s) this PR fixes:
Part of #65
Special notes for your reviewer:
The utility function is extracted to a separate package, which is not required for this task. However, it is used in the #578 PR to put it next to the analogous function for MPIJob. This way it is clear what is the list of prefixes in use.