-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RunFn to be able to handle relative source paths #3336
Conversation
Hi @aodinokov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aodinokov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
151e03d
to
95dfa70
Compare
95dfa70
to
a43839d
Compare
146d737
to
9a3ca89
Compare
9a3ca89
to
ec16498
Compare
@aodinokov: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's an attempt to propose some solution for kptdev/kpt#1151 for
bind
mount type.this test shows how
kustomize build
may benefit from that feature - it's possible to pass some additional files inside krm-function and use them there like they were local. In particular helm-inflator in this example takes values overrides in this way.The security perspective is covered by sandboxing non-absolute paths inside
StorageMountRoot
which is equal topath
inkustomize fn run <path>
or kustomization directory in case ofkustomize build
, but can be manually overriden by settingmount-root
parameter. non-absolute path will throw error ifmount-root
is empty.