Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwok] Have a version configuration to organize the parameters #4

Closed
wzshiming opened this issue Aug 2, 2022 · 4 comments · Fixed by #133
Closed

[kwok] Have a version configuration to organize the parameters #4

wzshiming opened this issue Aug 2, 2022 · 4 comments · Fixed by #133
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@wzshiming
Copy link
Member

Do we need to define a configuration for kwok?

I'd like to have a version configuration to organize the parameters. It's a local file, not configMap/CRD, just like scheduler config.

But defining CLI args is a good start.

Originally posted by @Huang-Wei in #1 (comment)

@wzshiming wzshiming mentioned this issue Aug 2, 2022
@wzshiming
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2022
@wzshiming wzshiming changed the title Have a version configuration to organize the parameters [kwok] Have a version configuration to organize the parameters Aug 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@wzshiming
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 7, 2022
@wzshiming
Copy link
Member Author

wzshiming commented Nov 9, 2022

# ~/.kwok/kwok.yml
kind: KwokConfiguration
apiVersion: kwok.x-k8s.io/v1alpha1
spec:
  cidr: ""
  disregardStatusWithAnnotationSelector: ""
  disregardStatusWithLabelSelector: ""
  manageAllNodes: false
  manageNodesWithAnnotationSelector: ""
  manageNodesWithLabelSelector: ""
  nodeIP: ""
# ~/.kwok/kwokctl.yml
kind: KwokctlConfiguration
apiVersion: kwok.x-k8s.io/v1alpha1
spec:
  workdir: ""
  kubeApiserverPort: 0
  runtime: ""
  prometheusPort: 0
  kwokVersion: ""
  kubeVersion: ""
  etcdVersion: ""
  prometheusVersion: ""
  securePort: false
  quietPull: false
  kubeImagePrefix: ""
  etcdImagePrefix: ""
  kwokImagePrefix: ""
  prometheusImagePrefix: ""
  etcdImage: ""
  kubeApiserverImage: ""
  kubeControllerManagerImage: ""
  kubeSchedulerImage: ""
  kwokControllerImage: ""
  prometheusImage: ""
  kindNodeImagePrefix: ""
  kindNodeImage: ""
  kubeBinaryPrefix: ""
  kubeApiserverBinary: ""
  kubeControllerManagerBinary: ""
  kubeSchedulerBinary: ""
  kubectlBinary: ""
  etcdBinaryPrefix: ""
  etcdBinary: ""
  etcdBinaryTar: ""
  kwokBinaryPrefix: ""
  kwokControllerBinary: ""
  prometheusBinaryPrefix: ""
  prometheusBinary: ""
  prometheusBinaryTar: ""
  mode: ""
  kubeFeatureGates: ""
  kubeRuntimeConfig: ""
  kubeAuditPolicy: ""
  kubeAuthorization: ""

Pod lifecycle simulation configuration #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants