Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Added README generator #809

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Added README generator #809

merged 2 commits into from
Jun 18, 2020

Conversation

Divya063
Copy link
Contributor

/assign @JimBugwadia

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Divya063. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2020
@Divya063 Divya063 changed the title added README generator Added README generator Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2020
@Divya063 Divya063 force-pushed the readme_render branch 4 times, most recently from 241ff44 to d52283b Compare June 18, 2020 03:32
@JimBugwadia
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020
JimBugwadia
JimBugwadia suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. added a minor comment

benchmarks/kubectl-mtb/docs/main.go Outdated
// Skip directories
log.Println(path, "is a directory, skipping...")
return nil
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary else

@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Divya063, JimBugwadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit f7eecb9 into kubernetes-retired:master Jun 18, 2020
@phoenixking25 phoenixking25 mentioned this pull request Jun 24, 2020
Closed
@Divya063 Divya063 mentioned this pull request Aug 24, 2020
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimBugwadia JimBugwadia JimBugwadia requested changes

@adrianludwin adrianludwin Awaiting requested review from adrianludwin

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@JimBugwadia JimBugwadia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Divya063 @k8s-ci-robot @JimBugwadia