Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Import cyclonus to network-policy-api repo #29

Closed
wants to merge 448 commits into from
Closed

[WIP] Import cyclonus to network-policy-api repo #29

wants to merge 448 commits into from

Conversation

astoycos
Copy link
Member

This PR moves https://github.com/mattfenwick/cyclonus to this repo, with all the legacy commits and tags.

@mattfenwick
add links to antrea jobs, krew plugin in readme
301ca38
@mattfenwick
remove unused explainer code, merge single-file package into matcher
071c2a0
@mattfenwick
Merge pull request kubernetes-sigs#38 from mattfenwick/remove-unused
40bb0f0 
remove unused explainer code, merge single-file package into matcher
@mattfenwick
first pass at test case flattening, plus tags
2ff5fd8
@mattfenwick
fold in upstream, example generators into tag system
7cdb623
@mattfenwick
fold in rules, targets test cases
03af6fd
@mattfenwick
fold in peer test cases
06e50d9
@mattfenwick
fold in action test cases
86f357e
@mattfenwick
fold in depth cases
7b8566b
@mattfenwick
add job, docker instructions to readme
69bd47a
@mattfenwick
remove obsolete generator
a2e8e45
@mattfenwick
eliminate fragment generator
ec63c8f
@mattfenwick
fold fragments into constants
e33d38a
@mattfenwick
fold in conflicts
fe496a8
@mattfenwick
Merge pull request kubernetes-sigs#39 from mattfenwick/tags
2858a9a 
add tags to test cases, so that tags can be used to include/exclude tests from each run
@mattfenwick
print out test case counts per tag
6b5d452
@mattfenwick
Merge pull request kubernetes-sigs#40 from mattfenwick/tags
37ae3d1 
print out test case counts per tag
@mattfenwick
fix up job yaml
a4abb78
@mattfenwick
add antrea, calico, cilium jobs; always print version from generate
2f97251
@mattfenwick
reduce number of 2-port test cases and reenable by default
20a9cf3
@mattfenwick
formatting
c0d01b1
@mattfenwick
use primary/subordinate structure for tags
cfec95a
@mattfenwick
allow kube probes to be mocked
373ae8d
@mattfenwick
improve tags, descriptions for peers + port/protocols
5ead14a
@mattfenwick
add in descriptions, tags for conflict test cases
3827283
@mattfenwick
split out type into separate file
666315b
@mattfenwick
extract summarization builder
dc6eabc
@mattfenwick
pull out constants into named variables
6fd343b
@mattfenwick
organize kube functionality; create mock kube mode
82a09a7
@mattfenwick
add markdown table printer, add pass rate
9015501
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2022
@mattfenwick
Copy link
Contributor

/lgtm /approve

@mattfenwick
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@mattfenwick: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, mattfenwick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matmerr
Copy link
Contributor

matmerr commented Feb 28, 2022

+1, big fan of this, we've been using cyclonus for ~1y and it's been super useful

@mattfenwick
Copy link
Contributor

What's next steps for this @astoycos ?

@astoycos
Copy link
Member Author

astoycos commented Apr 6, 2022

So really there's nothing blocking this @mattfenwick , however I do think It would easier to let #30 merge first to make sure we work around the directory structure/tools of the CRD since it's a bit more crucial we get that in.

@k8s-ci-robot
Copy link
Contributor

@astoycos: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2022
@astoycos astoycos mentioned this pull request Aug 18, 2022
Closed
@tssurya tssurya mentioned this pull request Sep 12, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2022
@astoycos
Copy link
Member Author

Close in favor of #39

@astoycos astoycos closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiraut abhiraut Awaiting requested review from abhiraut

@rikatz rikatz Awaiting requested review from rikatz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@astoycos @mattfenwick @k8s-ci-robot @matmerr @k8s-triage-robot @dougsland @jayunit100 @johnSchnake