Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update deps #1422

Merged
merged 2 commits into from
Oct 20, 2023
Merged

go.mod: update deps #1422

merged 2 commits into from
Oct 20, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 20, 2023

The gist of these updates is to update the opentelemetry packages to versions with the latest security fixes.

Supersedes #1419 and #1420 from @dependabot.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 29b67d0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6532569be944050008c10199
😎 Deploy Preview https://deploy-preview-1422--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
ArangoGutierrez
ArangoGutierrez approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2213d91d6dc00814f6190dd825c0e50073492895

@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

Let's wait for #1421
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@marquiz
go.mod: update deps
e83a64a 
The gist of these updates is to update the opentelemetry packages to
versions with the latest security fixes.
@marquiz
go.mod: bump kubernetes to v1.28.3
29b67d0
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

@ArangoGutierrez rebased, plus added a commit that bumps k8s to v1.28.3

ArangoGutierrez
ArangoGutierrez approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7b4becdd97649605ac48e9609e9f2789cb51dca

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

/retest

@marquiz
Copy link
Contributor Author

marquiz commented Oct 20, 2023

/test pull-node-feature-discovery-build-image-cross-generic

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1422 (29b67d0) into master (5b3f4ce) will increase coverage by 0.17%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   30.33%   30.50%   +0.17%     
==========================================
  Files          58       58              
  Lines        7481     7500      +19     
==========================================
+ Hits         2269     2288      +19     
  Misses       4965     4965              
  Partials      247      247

see 1 file with indirect coverage changes

@k8s-ci-robot k8s-ci-robot merged commit 6144f3d into kubernetes-sigs:master Oct 20, 2023
12 checks passed
@marquiz marquiz deleted the devel/deps branch October 20, 2023 15:03
This was referenced Oct 20, 2023
Merged
Merged
@marquiz marquiz mentioned this pull request Dec 20, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez