Skip to content

Conversation

lalitc375
Copy link
Contributor

This pull request introduces a significant number of new test cases to our test suite. These tests cover a wide range of scenarios involving unicode characters, escape sequences, and other special characters within field paths and values.

Motivation:

The primary motivation for this change is to increase our test coverage and make the codebase more robust. This will be particularly important for future work that may involve switching the underlying JSON serialization and deserialization library to std. Having a comprehensive test suite will enable us to:

  • Validate new libraries: We can confidently evaluate and validate new JSON libraries for compatibility with our existing system.
  • Prevent regressions: A strong test suite will help us catch any regressions or behavioral changes that might be introduced by a new library.

By strengthening our tests now, we are paving the way for future improvements and ensuring the long-term stability and performance of our code.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @lalitc375!

It looks like this is your first PR to kubernetes-sigs/structured-merge-diff 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/structured-merge-diff has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @lalitc375. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2025
@lalitc375
Copy link
Contributor Author

cc: @liggitt @jpbetz

@liggitt
Copy link
Contributor

liggitt commented Sep 9, 2025

/ok-to-test

Thanks, looks good at first glance

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
@liggitt
Copy link
Contributor

liggitt commented Sep 9, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2025
@lalitc375 lalitc375 requested a review from liggitt September 9, 2025 20:55
@liggitt
Copy link
Contributor

liggitt commented Sep 9, 2025

/lgtm
/assign @jpbetz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Sep 10, 2025

Excellent. Given how (excessively) accepting we are of field names in CRDs, this makes me feel a lot better about our coverage.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, lalitc375, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 789a688 into kubernetes-sigs:master Sep 10, 2025
6 checks passed
@lalitc375 lalitc375 deleted the test-coverage branch September 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants