-
Notifications
You must be signed in to change notification settings - Fork 70
feat(testing): Add comprehensive tests for unicode and special characters #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @lalitc375! |
Hi @lalitc375. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Thanks, looks good at first glance |
/lgtm |
666d900
to
544b1e3
Compare
/lgtm |
Excellent. Given how (excessively) accepting we are of field names in CRDs, this makes me feel a lot better about our coverage. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, lalitc375, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request introduces a significant number of new test cases to our test suite. These tests cover a wide range of scenarios involving unicode characters, escape sequences, and other special characters within field paths and values.
Motivation:
The primary motivation for this change is to increase our test coverage and make the codebase more robust. This will be particularly important for future work that may involve switching the underlying JSON serialization and deserialization library to std. Having a comprehensive test suite will enable us to:
By strengthening our tests now, we are paving the way for future improvements and ensuring the long-term stability and performance of our code.