FixTabsOrDie doesn't work well with YAML structs #66
Conversation
Especially when the struct is in a list because: ```yaml - a: 1 b: 2 ``` panics because of mixed spaces and tabs. A working alternative is to indent with tabs, but I don't think it's very pleasant: ```yaml - a: 1 b: 2 ``` Update the code so that prefixed tabs from the first line are removed from all consecutive lines, and keep it that simple.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
I don't care that much whether we use tabs or spaces, but doesn't mixing them feel pretty bad? Specifically it means you could use tabs on one line and spaces on the next, and even though that would (might!) look visually very different, it'd mean the same thing? We don't have gofmt helping us out here. (I don't care enough to write more than this about it though :) ) |
|
I think this has value in making the tests more readable. I don't think it would allow you to use tabs on one line and spaces on the next, it just trims the same number of tabs off the beginning of each line, and yaml will expect all spaces after that, right? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Especially when the struct is in a list because:
panics because of mixed spaces and tabs. A working alternative is to
indent with tabs, but I don't think it's very pleasant:
Update the code so that prefixed tabs from the first line are removed
from all consecutive lines, and keep it that simple.
/assign @lavalamp @jennybuckley @kwiesmueller