Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[File Vanilla e2e test fix]: Fixing intermittent test issues in File Vanilla Pipelines #2822

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[File Vanilla e2e test fix]: Fixing intermittent test issues in File Vanilla Pipelines #2822

merged 1 commit into from
Mar 18, 2024

Conversation

rpanduranga
Copy link
Contributor

@rpanduranga rpanduranga commented Mar 13, 2024 •
edited
Loading

What this PR does / why we need it:
[File Vanilla e2e test fix]: Fixing intermittent test issues in File Vanilla Pipelines

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
NA

Testing done:
Before Fix:
https://container-dp.svc.eng.vmware.com/view/Pre-Checkin-CSI/job/csi-file-vanilla-precheckin/819/

After Fix:
https://container-dp.svc.eng.vmware.com/view/Pre-Checkin-CSI/job/csi-file-vanilla-precheckin/820/
https://container-dp.svc.eng.vmware.com/view/Pre-Checkin-CSI/job/csi-file-vanilla-precheckin/818/

https://gist.github.com/rpanduranga/9974a8eedf6727b3652c5c7d560b1721

https://gist.github.com/rpanduranga/48fd47fcaa80453255e16efd4f3a8eb0

https://gist.github.com/rpanduranga/3e1e57e2873e87d48b8f1a5c3cb07abe

Special notes for your reviewer:
NA

Release note:
NA

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rpanduranga. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2024
@rpanduranga rpanduranga force-pushed the file-e2e-test-fix branch 2 times, most recently from 80b4784 to faefa8e Compare March 13, 2024 11:06
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
@rpanduranga rpanduranga changed the title [WIP]: [File Vanilla e2e test fix]: Fixing intermittent test issues in File Vanilla Pipelines [File Vanilla e2e test fix]: Fixing intermittent test issues in File Vanilla Pipelines Mar 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
@kavyashree-r
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
sashrith
sashrith reviewed Mar 15, 2024
View reviewed changes
tests/e2e/csi_cns_telemetry.go Outdated
@@ -191,6 +191,12 @@ var _ = ginkgo.Describe("[csi-block-vanilla] [csi-file-vanilla] [csi-block-vanil
gomega.Expect(err).NotTo(gomega.HaveOccurred())
}()

// For Old PVCs to reflect the latest Cluster-Distribution Value, wait for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of static sleep let's add a call to force trigger a full sync via the crd

@rpanduranga rpanduranga force-pushed the file-e2e-test-fix branch 2 times, most recently from 7b9fc2f to 52a97fb Compare March 18, 2024 06:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rpanduranga, sashrith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2024
@sashrith
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 18, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit c59551e into kubernetes-sigs:master Mar 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashrith sashrith sashrith approved these changes

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

Assignees

@sashrith sashrith

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpanduranga @k8s-ci-robot @kavyashree-r @sashrith