Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Thumbprint based on login for multi vCenter deployment #2858

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Apr 18, 2024

What this PR does / why we need it:
fix Thumbprint based on login for multi vCenter deployment

Which issue this PR fixes
fixes ##2823

Testing done:
Done.

Verified Creating PVC and Pod using following config on multi vCenter deployment

[Global]
cluster-distribution = "CSI-Vanilla"
csi-fetch-preferred-datastores-intervalinmin = 1
query-limit = 3
list-volume-threshold = 1

[VirtualCenter "VC-1-IP"]
insecure-flag = "true"
user = "Administrator@vsphere.local"
password = "PSPSh-2lv1Y-beHe"
port = "443"
thumbprint = "7F:81:BC:50:DB:AD:0C:9E:33:4A:75:57:92:5A:5A:FB:28:BD:D6:A5:2E:26:9A:DC:9B:02:8D:5C:A8:B4:D4:BC"
datacenters = "VSAN-DC"

[VirtualCenter "VC-2-IP"]
insecure-flag = "true"
user = "Administrator@vsphere.local"
password = "PSPSh-2lv1Y-beHe"
port = "443"
thumbprint = "47:BF:44:18:ED:22:C1:D0:61:59:7C:ED:24:39:C0:71:10:66:BC:66:A1:A8:C6:96:EE:43:21:43:F9:CA:BE:CE"
datacenters = "VSAN-DC"

[VirtualCenter "VC-3-IP"]
insecure-flag = "true"
user = "Administrator@vsphere.local"
password = "PSPSh-2lv1Y-beHe"
port = "443"
thumbprint = "98:4B:78:EC:1F:D3:9E:9D:F2:F1:7C:98:C3:0F:77:3F:59:7C:36:C2:E2:1B:14:7A:5B:BF:73:8A:97:84:9C:26"
datacenters = "VSAN-DC"

[Snapshot]
global-max-snapshots-per-block-volume = 3

[Labels]
topology-categories="k8s-zone" 

Special notes for your reviewer:

Release note:

fix Thumbprint based on login for multi vCenter deployment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2024
@divyenpatel
Copy link
Member Author

@chethanv28 I have updated testing done section on the PR.
Can you help merge this PR?

Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 54950ee into kubernetes-sigs:master Apr 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants