Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Client and API types #74

Closed
DirectXMan12 opened this issue Jan 19, 2017 · 7 comments
Closed

Kubelet Client and API types #74

DirectXMan12 opened this issue Jan 19, 2017 · 7 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@DirectXMan12
Copy link
Contributor

Kubelet exposes the stats API (https://github.com/kubernetes/kubernetes/tree/master/pkg/kubelet/api/v1alpha1/stats) as well as an associated client (https://github.com/kubernetes/kubernetes/tree/master/pkg/kubelet/client). Heapster uses these to talk to the the legacy stats API and the summary API (see https://github.com/kubernetes/heapster/tree/master/metrics/sources/kubelet and https://github.com/kubernetes/heapster/tree/master/metrics/sources/kubelet).

Having those API types and the client code here (or in a separate repo) would be useful, since it would work towards removing the circular dependency between Heapster and Kubernetes.

cc @deads2k @lavalamp

@DirectXMan12
Copy link
Contributor Author

@dashpole's proposed "Core Metrics API" (kubernetes/community#252) will most likely have a similar issue.

In the longer term, the API definitions for the metrics APIs shouldn't live in Heapster, but not requiring Heapster to vendor k8s proper would be nice in and of itself (seeing as it's a client of Kubernetes, mainly, that happens to take advantage of some of the shared API server code that's being split out).

@deads2k
Copy link
Contributor

deads2k commented Jan 20, 2017

This client project may just be for speaking to an API server, but this does highlight a need to do something similar for the kubelet or to break the kubelet out of k8s.io/kubernetes to avoid the cycle.

@lavalamp
Copy link
Member

lavalamp commented Jan 20, 2017 via email

@deads2k
Copy link
Contributor

deads2k commented Jan 20, 2017

I think once we're developing the client in a separate repo we could
actually do this but it would make things even more convoluted to add it in
right now? I could be wrong. I'm not opposed to this.

It might not be too bad in 1.6 (february). We're actually getting pretty close to eliminating most of the code vendored from k8s.io/kubernetes.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Jan 3, 2018

We've got our own copy in Heapster for the moment, and that's "ok" until something changes with those APIs, since this issue isn't going anywhere.

@yashbhutwala
Copy link

yashbhutwala commented Nov 24, 2019

Discovered this issue while trying to #716. @DirectXMan12 or @deads2k, any updates on integrating the clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

7 participants