Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve/Unify permission issues with SIG Meeting Notes in a way that is transparent. #3159

Closed
8 tasks
jayunit100 opened this issue Jan 28, 2019 · 29 comments
Closed
8 tasks
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@jayunit100
Copy link
Member

jayunit100 commented Jan 28, 2019

We currently have several meeting agenda google docs which aren't open to the public....

Since we're 100% community driven, that should be changed soon, IMO across the board so that

  • all mtng agendas are publically available to anyone on the interweb,
  • the development process and any communication we note down should be 100% non-dependent on google-specific logins.

I've made a quick list here.

I can reach out to the individual SIGs about this over the next few days.

Closed : Need to be made public

Open : No action required.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 28, 2019
@jayunit100
Copy link
Member Author

/sig community

@castrojo
Copy link
Member

/sig contributor-experience

Thanks for working on this!

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2019
@cblecker
Copy link
Member

/cc @parispittman @Phillels @nikhita

Is there a reason for some being closed vs open? were we having moderation issues?

@parispittman
Copy link
Contributor

@cblecker - some where probably created by googlers where we have restricted sharing perms. in those cases, they most likely shared it with their mailing list only and not k-dev. someone will need to audit this and then have them share with k-dev, too, if you can't see them.

@parispittman
Copy link
Contributor

if they want it open to the public and not just k-dev, they will need to be copied and transferred over to a new owner that doesn't have permissions issues like a @gmail account. This will need to be documented, too, at the top of the document because if this person would leave, they take the doc with them.

@parispittman
Copy link
Contributor

it may be worthwhile holding on this until we can get the contribex gsuite ironed out and then we can figure out team drive for centralized ownership of documents. i think we may still have "public" issues with access to that though.

@jayunit100
Copy link
Member Author

How about copy/paste -> New doc ? At least in the short term, that will solve the existing issue.

@parispittman
Copy link
Contributor

we will need to find all of the dependancies where we link to our meeting notes - one of which is the meeting invites. will need to regen those, too. if we could get a checklist of what a sig lead needs to do here, that will be best. another example - only give edit rights to those in your mailing list, etc.

@parispittman
Copy link
Contributor

@mrbobbytables can you add this to: #3160?

@mrbobbytables
Copy link
Member

Updated to include a note on sharing the docs.

@liggitt
Copy link
Member

liggitt commented Jan 31, 2019

most of the docs are intentionally shared with specific mailing lists (kubernetes-dev and the sig mailing list). most of the anonymously visible docs referenced above share zoom meeting ids, which goes against the guidelines at https://github.com/kubernetes/community/blob/master/communication/zoom-guidelines.md#setting-up-your-meeting-and-moderation

@lavalamp
Copy link
Member

At least for api machinery, I object to describing it as "closed"; it's shared with kubernetes-announce, kubernetes-dev, and kubernetes-sig-api-machinery.

The title, which used to be viewable just by clicking on the link, has joining instructions, but it seems it's no longer visible without logging in :(

@jayunit100
Copy link
Member Author

Per https://github.com/kubernetes/community/pull/3160/files#diff-3dd56b6252307b3ebd4082bdd70317a1R119 , the view permissions need to be modified.

Or revert that merge.

@parispittman
Copy link
Contributor

@jayunit100 - we have some zoom issues that we are addressing right now. once that is cleared up re: #2536, we will be able to fully implement those new view perm guidelines.

@jayunit100
Copy link
Member Author

+1 , we can keep it open till then

@mourya007
Copy link

Agree with the point, because most of the places google mails are not easy to access. So we should have a public process for everyone.

@saad-ali
Copy link
Member

saad-ali commented Feb 1, 2019

@jayunit100 SIG Storage meeting notes (link) are shared publicly and have always been (see attached screenshot). Can you please clarify why we are listed as Closed : Need to be made public?

sig-storage-notes-access
)

@jayunit100
Copy link
Member Author

@saad-ali your right ! Fixed, sorry, alot of links there. no idea how that slipped into the wrong bin.

@jayunit100 jayunit100 changed the title Open SIG meeting notes Open (as in 'you can curl it') All SIG meeting notes Feb 1, 2019
@castrojo
Copy link
Member

castrojo commented Feb 1, 2019

I wanted to add some comments from slack:

So I think the issue here is the governance isn't explicit:
https://github.com/kubernetes/community/blob/master/sig-governance.md#sig-governance (edited)

  • Keep up-to-date meeting notes, linked from the SIG's page in the community repo
  • Announce meeting agenda and minutes after each meeting, on their SIG mailing list
  • Record SIG meeting and make it publicly available

We only really say that the recording must be made publically available. Now, I personally would assume that that means that there's an implied task that if your meeting recording is public, then clearly your meeting notes should be.

However, you could also interpret that as "I shared it my with list, so people who care about my SIG notes already have access."

This is all a symptom of initial SIG docs being used with work gsuites with restrictive sharing, so we cheat by ACLing in a mailing list to allow anyone on the list to access the document. Because if I'm a chair I have better things to do than managing sharing gdoc requests from the entire internet.

Perhaps a solution is perhaps "Do users have the ability to figure out how to get to your notes? Mentioned in the SIG readme, or slack channel pinned topic or something along those lines. Maybe something like "SIG Agenda Notes (link) (New users, join this list to get access to our discussions") or something wordsmithed better to show that it's a tool workaround problem, not a SIG trying to hide something from you.

I've mentioned this in a contribex mailing list post in the past, we have spent some time looking into fixing this problem but nothing quite fixes it for us, or we would end up migrating to a new tool and open a different set of problems that might be worse or make everyone have to open a new account on a new service, etc. So the mantra so far has unfortunately been stick with the bugs you know unless we for sure have something that will make it easier for everyone.

@castrojo castrojo changed the title Open (as in 'you can curl it') All SIG meeting notes Address permission issues with SIG Notes in a way that is transparent Feb 1, 2019
@jayunit100
Copy link
Member Author

+1 for renaming the issue, thats probably a better title for it . Thanks for helping move this along @castrojo

@parispittman
Copy link
Contributor

I'm seeing the perms on contribex as anyone on the internet can find and view. What's the error that is displaying?

screen shot 2019-02-04 at 1 32 04 am

@jayunit100
Copy link
Member Author

jayunit100 commented Feb 6, 2019

I'm seeing the perms on contribex as anyone on the internet can find and view. What's the error that is displaying?

screen shot 2019-02-04 at 1 32 04 am

Hmm, looks like it requires you to be logged in to google to me (contrib-ux, right?) : https://docs.google.com/document/d/1qf-02B7EOrItQgwXFxgqZ5qjW0mtfu5qkYIF1Hl4ZLI/ ?

@jayunit100 jayunit100 changed the title Address permission issues with SIG Notes in a way that is transparent Resolve/Unify permission issues with SIG Meeting Notes in a way that is transparent. Feb 6, 2019
@parispittman
Copy link
Contributor

Yes, that is correct. That's where I took the above screenshot - you should be able to view it.

@jayunit100
Copy link
Member Author

jayunit100 commented Feb 6, 2019

hmmm, no it wont let me ... assuming its related to who your logged in as?
screen shot 2019-02-06 at 7 38 43 am

@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

What else needs to be done here?

Do we require the meeting notes to be viewable to the Public? I don't think we impose that, from https://github.com/kubernetes/community/blob/master/communication/mailing-list-guidelines.md#mailing-list-creation.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests