Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more instructions on WG creation. #1986

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

kimsterv
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 29, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 29, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 29, 2018
@kimsterv
Copy link
Contributor Author

CLA signed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 29, 2018
@cblecker
Copy link
Member

kubernetes/steering#27

cc: @kubernetes/steering-committee

@bgrant0607
Copy link
Member

Thanks! This is a good start. This is effectively how we've operated.

Is there anything you think we should add in this PR @mattfarina? We could also add more in follow-up PRs.

governance.md Outdated
Working groups typically have a Slack channel as well as regular meetings.
It's encouraged to keep a clear record of all accomplishments that's
publicly accessible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we have required SIGs to sponsor working groups. Do we require a SIG to sponsor a working group, or can a WG be formed independently of any SIG?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Kim to update with the SIG sponsor info (as well as some other things). Looking back on several previous WG creations, there was at least one sponsoring sig pre-proposal.

@michelleN
Copy link

Looks like #1994 is also adding some detail on WG.
I propose we accept this PR after Kim gets a chance to add the bit on sponsor SIGs and then review #1994 since it's a bit more involved. Is that okay with you @jbeda ?

@jbeda
Copy link
Contributor

jbeda commented Apr 2, 2018

It looks like they are touching the same files but don't significantly overlap. My PR doesn't go into how WGs are formed but more about what they are compared to the other groups. I think there there is some open questions around how WGs are formed and added a comment above.

@idvoretskyi
Copy link
Member

/cc

@kimsterv
Copy link
Contributor Author

kimsterv commented Apr 6, 2018

/assign @bgrant0607

@cblecker
Copy link
Member

cblecker commented Apr 6, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 6, 2018
@idvoretskyi
Copy link
Member

Anything that blocks us from merging it now?

@bgrant0607
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6c3b1a6 into kubernetes:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants