sig-cl: resolve some warnings with the maintainers tool + governance updates

[neolit123]

list of commits:

sig-cl: update CONTRIBUTING.md

- Fix malformed link
- Include link to VODs

sig-cl: remove the kubespray Zoom meeting

As discussed with the kubespray maintainers:
https://kubernetes.slack.com/archives/C2V9WJSJD/p1643716538243509[](https://github.com/neolit123)

Their Zoom meeting is no longer active.
The maintainers expressed that Slack is sufficient for them
and we should remove the meeting from the calendar for the time being.

Remove the meeting from sigs.yaml
It was also removed from the SIG CL calendar.

sig-cl: resolve some warnings with the maintainers tool

- Remove kube-up as a subproject. The tool correctly discovers that
we do not have OWNERS under k/k/cluster.
- Add mailing list / slack / description to projects that did not
have it.
- Rename kops -> kOps to match the project rename that happened
some time ago.
- Add more OWNERS URLs in the kubeadm subproject section. These are
not kubeadm specific repositories, but kubeadm is the best
fit given the top level SIG struct does not have OWNERS.

---

list of ERRORS from the maintainers tool:

• first two will be resolved with fixes in the repositories:
  unknown field "emeritus_maintainers" in the OWNERS file kubernetes-sigs/cluster-api-provider-aws#3104
  unknown field "emeritus_maintainers" in the OWNERS file kubernetes-sigs/cluster-api-provider-openstack#1122
• third one is unknown

~/go/bin/maintainers --kubernetes-directory=/home/lubo/go/src/k8s.io/kubernetes audit sig-cluster-lifecycle | grep ERROR
ERROR: unable to parse owners file at https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-aws/master/OWNERS url - error unmarshaling JSON: while decoding JSON: json: unknown field "emeritus_maintainers"
ERROR: unable to parse owners file at https://raw.githubusercontent.com/kubernetes-sigs/cluster-api-provider-openstack/master/OWNERS url - error unmarshaling JSON: while decoding JSON: json: unknown field "emeritus_maintainers"
ERROR: unable to read file /home/lubo/go/src/k8s.io/kubernetes/_output/local/go/pkg/mod/k8s.io/kube-openapi@v0.0.0-20210421082810-95288971da7e/OWNERS - error unmarshaling JSON: while decoding JSON: json: unknown field "emritus_approvers"

list of warnings BEFORE this change:

``` WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: missing 'description' key WARNING: missing 'contact' key WARNING: needs labels reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/OWNERS WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/OWNERS WARNING: missing 'meetings' key WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kubeadm/OWNERS WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: missing 'description' key WARNING: missing 'mailing_list' in contact WARNING: file staging/src/k8s.io/cluster-bootstrap/OWNERS should be in one of ["sig-cluster-lifecycle"] based on labels/aliases WARNING: file staging/src/k8s.io/component-base/configz/OWNERS should be in one of ["sig-cluster-lifecycle"] based on labels/aliases WARNING: file staging/src/k8s.io/component-base/featuregate/OWNERS should be in one of ["sig-api-machinery" "sig-cluster-lifecycle"] based on labels/aliases WARNING: file test/e2e/lifecycle/OWNERS should be in one of ["sig-cluster-lifecycle"] based on labels/aliases WARNING: file test/e2e_kubeadm/OWNERS should be in one of ["sig-cluster-lifecycle"] based on labels/aliases ```

list of WARNINGS after this change:

WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/cmd/kubeadm/OWNERS
WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/e2e/lifecycle/OWNERS
WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/test/e2e_kubeadm/OWNERS
WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/component-base/configz/OWNERS
WARNING: needs an alias as approver/reviewer reflecting sig-cluster-lifecycle - https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/component-base/featuregate/OWNERS

these seem to be due to missing SIG-CL in OWNER_ALIAS files (?) and maybe should be optional.

[neolit123]

/kind cleanup
/sig cluster-lifecycle
/priority backlog
/triage accepted
/hold
for comments

[neolit123]

Q: would it make sense to have omitempty in the YAML spec for meetings?

with the following patch:

diff --git a/generator/app.go b/generator/app.go
index bae4903e..fbd8ee8b 100644
--- a/generator/app.go
+++ b/generator/app.go
@@ -84,10 +84,10 @@ type Person struct {
 // Meeting represents a regular meeting for a group.
 type Meeting struct {
        Description   string
-       Day           string
-       Time          string
-       TZ            string
-       Frequency     string
+       Day           string `yaml:",omitempty"`
+       Time          string `yaml:",omitempty"`
+       TZ            string `yaml:",omitempty"`
+       Frequency     string `yaml:",omitempty"`
        URL           string `yaml:",omitempty"`
        ArchiveURL    string `yaml:"archive_url,omitempty"`
        RecordingsURL string `yaml:"recordings_url,omitempty"`
diff --git a/generator/sig_readme.tmpl b/generator/sig_readme.tmpl
index 4bb61997..54f8c60f 100644
--- a/generator/sig_readme.tmpl
+++ b/generator/sig_readme.tmpl
@@ -92,7 +92,7 @@ The following [subprojects][subproject-definition] are owned by sig-{{.Label}}:
   - [Mailing List]({{.Contact.MailingList}})
 {{- end }}
 {{- if .Contact.GithubTeams }}
-  - GitHub Teams: 
+  - GitHub Teams:
 {{- range .Contact.GithubTeams }}
     - [@kubernetes/{{.Name}}](https://github.com/orgs/kubernetes/teams/{{.Name}}) {{- if .Description }} - {{.Description}}{{- end}}
 {{- end }}
@@ -101,7 +101,7 @@ The following [subprojects][subproject-definition] are owned by sig-{{.Label}}:
 {{- if .Meetings }}
 - **Meetings:**
 {{- range .Meetings }}
-  - {{.Description}}: [{{.Day}}s at {{.Time}} {{.TZ}}]({{.URL}}) ({{.Frequency}}). [Convert to your timezone](http://www.thetimezoneconverter.com/?t={{.Time}}&tz={{.TZ | tzUrlEncode}}).
+  - {{.Description}}{{- if .Day }}: [{{.Day}}s at {{.Time}} {{.TZ}}]({{.URL}}) ({{.Frequency}}). [Convert to your timezone](http://www.thetimezoneconverter.com/?t={{.Time}}&tz={{.TZ | tzUrlEncode}}).{{- end}}
 {{- if .ArchiveURL }}
     - [Meeting notes and Agenda]({{.ArchiveURL}}).
 {{- end }}

it allows us to do things like:

     meetings:
     - description: Use the main Cluster API meeting
-      day: ""
-      time: ""
-      tz: ""
-      frequency: ""

this would tell the user, "yes, there is a meeting, but not a specific one for this subproject and you can go to another meeting".

WDYT?

EDIT: included as first commit here.

[neolit123]

/cc @fabriziopandini

[fabriziopandini]

/lgtm
for the changes to sigs.yaml
also, I notice that cluster-api-operator is missing; might be worth cross-checking is also if someone else is missing and then open issues in their repositories

[neolit123]

also, I notice that cluster-api-operator is missing; might be worth cross-checking is also if someone else is missing and then open issues in their repositories

yep, some could be missing. they can be added in a follow up.
as part of the repository / subproject creations we should tell the elected maintainers to PR the new subproject into sigs.yaml and we can LGTM the PR.

[alexander-demicev]

I requested slack channel for CAPI operator #6404, I'll update the PR #6304 when it's ready.

[fabriziopandini]

@neolit123 I have checked all the CAP* providers and all of them are listed except Cluster API operator which will be fixed by the PR linked above. Nevertheless, I have asked the various team to update sub-project info, given that in some cases they are incomplete (e.g lack of slack channel, etc.)

[dims]

/assign @mrbobbytables
/unassign

@neolit123 looks good in general, want to let sig-contribex folks look at the changes proposed in the tools

[mrbobbytables]

looping in TLs 👍
/assign @cblecker @nikhita

[neolit123]

i'm considering dropping the first commit here - generator: allow only description under subproject meetings...and leaving some subprojects without a zoom call info until further notice.
the maintainers tool currently complains (warning level) if a subproject does not have a meetings struct, but AFAIK there is no clear requirement for subprojects to have zoom calls.

e.g. kubespray expressed that they don't want to have a zoom call and slack / github is enough for them.

[neolit123]

dropped the first commit and left some subprojects without meetings descriptions (as they were before).
the PR no longer touches the generator. PTAL for approval.

[mrbobbytables]

/approve

[neolit123]

/cc @dims
PTAL for LGTM

to unblock the SIG yearly report.

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mrbobbytables, neolit123, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dims,mrbobbytables]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment