-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Hugo version to 0.112 #374
Bump Hugo version to 0.112 #374
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@sftim so the issue is the preview rather than the Hugo version? |
I think there is a real problem here; it's harder to see what that is because my local preview is - right now - missing the generated content either way. We shouldn't merge this change as-is. PR #375 may help us to find a newer Hugo version that nonetheless works OK, and that find may then help us spot what to change so that we can upgrade further. |
e035656
to
6b9c666
Compare
We can work around the Hugo problem by setting |
6b9c666
to
ae658f1
Compare
I think this is good to unhold - check the site, it looks right with the latest fixes. We can remove those once a separate PR updates Docsy. |
ae658f1
to
5a19ef3
Compare
Also, update local container image build (copy approach from k/website)
Apply adaptations to Docsy, pending future update to a more recent Docsy theme. These changes let the site build after an upgrade to Hugo. We can remove them once we upgrade Docsy.
5a19ef3
to
43087b9
Compare
This seems fine. Clicked around the preview a bunch and it looks good. /lgtm |
Thanks /hold cancel |
FWIW I've compared things side-by-side and didn't find any different, looks good. |
Bump Hugo version to
0.1100.112 (preview).There is build-time warning:
Also, update local preview using a container image (copy approach from k/website
Makefile
). The container image now mounts this Git repo read-only.Helps with #360