Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Hugo version to 0.112 #374

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 18, 2023

Bump Hugo version to 0.110 0.112 (preview).

There is build-time warning:

.Path when the page is backed by a file is deprecated and will be removed in a future release. We plan to use Path for a canonical source path and you probably want to check the source is a file. To get the current behaviour, you can use a construct similar to the one below:


  {{ $path := "" }}
  {{ with .File }}
	{{ $path = .Path }}
  {{ else }}
	{{ $path = .Path }}
  {{ end }}

Also, update local preview using a container image (copy approach from k/website Makefile). The container image now mounts this Git repo read-only.

Helps with #360

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2023
@mrbobbytables
Copy link
Member

/hold
This does break the site a bit - take a look at the side menu on the preview vs the actual site:
https://deploy-preview-374--kubernetes-contributor.netlify.app/docs/
https://kubernetes.dev/docs/

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2023
@jberkus
Copy link
Contributor

jberkus commented Feb 28, 2023

@sftim so the issue is the preview rather than the Hugo version?

@sftim
Copy link
Contributor Author

sftim commented Feb 28, 2023

I think there is a real problem here; it's harder to see what that is because my local preview is - right now - missing the generated content either way.

We shouldn't merge this change as-is.

PR #375 may help us to find a newer Hugo version that nonetheless works OK, and that find may then help us spot what to change so that we can upgrade further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@sftim sftim force-pushed the 20230218_bump_hugo_version branch from e035656 to 6b9c666 Compare April 19, 2023 12:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023
@sftim
Copy link
Contributor Author

sftim commented May 22, 2023

We can work around the Hugo problem by setting GOMAXPROCS to 1

@sftim sftim force-pushed the 20230218_bump_hugo_version branch from 6b9c666 to ae658f1 Compare May 24, 2023 21:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2023
@sftim sftim changed the title Bump Hugo version to 0.110 Bump Hugo version to 0.112 May 24, 2023
@sftim
Copy link
Contributor Author

sftim commented May 24, 2023

I think this is good to unhold - check the site, it looks right with the latest fixes.

We can remove those once a separate PR updates Docsy.

@sftim sftim force-pushed the 20230218_bump_hugo_version branch from ae658f1 to 5a19ef3 Compare May 24, 2023 21:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2023
@sftim sftim mentioned this pull request May 24, 2023
Also, update local container image build (copy approach from k/website)
Apply adaptations to Docsy, pending future update to a more recent Docsy
theme.

These changes let the site build after an upgrade to Hugo. We can remove
them once we upgrade Docsy.
@sftim sftim force-pushed the 20230218_bump_hugo_version branch from 5a19ef3 to 43087b9 Compare August 20, 2023 22:34
@cblecker
Copy link
Member

This seems fine. Clicked around the preview a bunch and it looks good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@sftim
Copy link
Contributor Author

sftim commented Aug 21, 2023

Thanks

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3af64f3 into kubernetes:master Aug 21, 2023
4 checks passed
@sftim sftim deleted the 20230218_bump_hugo_version branch August 21, 2023 16:04
@fsmunoz
Copy link
Contributor

fsmunoz commented Aug 25, 2023

FWIW I've compared things side-by-side and didn't find any different, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants