Skip to content

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Feb 3, 2016

I propose that we start with version 0.1 and use semantic versioning.

@bryk
Copy link
Contributor Author

bryk commented Feb 3, 2016

@cheld @floreks Can you take a look?

@floreks
Copy link
Member

floreks commented Feb 3, 2016

Starting version is fine. As for the semantic versioning I think more common format is:

0.1.0-alpha.1 or 0.1.0-alpha-1

I like first better. What do you think?

@codecov-io
Copy link

Current coverage is 79.06%

Merging #328 into master will not affect coverage as of 98dc671

@@            master    #328   diff @@
======================================
  Files           68      68       
  Stmts          554     554       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            438     438       
  Partial          0       0       
  Missed         116     116       

Review entire Coverage Diff as of 98dc671

Powered by Codecov. Updated on successful CI builds.

@lavvy
Copy link

lavvy commented Feb 3, 2016

I think I prefer the second option
On Feb 3, 2016 10:58 AM, "Sebastian Florek" notifications@github.com
wrote:

Starting version is fine. As for the semantic versioning I think more
common format is:

0.1.0-alpha.1 or 0.1.0-alpha-1

I like first better. What do you think?


Reply to this email directly or view it on GitHub
#328 (comment).

@bryk
Copy link
Contributor Author

bryk commented Feb 3, 2016

I didn't want to add hyphen, because kubernetes addons have a requirement to not have it in the version (yeah, that's sad). So how about going with just 0.1.0 for start? This what http://semver.org/ advises for initial pre-release development.

@floreks
Copy link
Member

floreks commented Feb 3, 2016

Yeah, that's disappointing. I'd go with clean 0.1.0 then.

PS. Does 0.1.0.alpha.1 look that bad?

@bryk
Copy link
Contributor Author

bryk commented Feb 3, 2016

BTW. Does 0.1.0.alpha.1 look that bad?

It does not, but semver needs a dash between FOO.BAR.BAZ and alpha.1

@floreks
Copy link
Member

floreks commented Feb 3, 2016

Oh yeah. I see now. Due to our proxy I could not open semver page correctly...

@luxas
Copy link
Member

luxas commented Feb 3, 2016

The best version would be v0.1.0-alpha.1 as Kubernetes core (e.g. v1.2.0-alpha.7), but v0.1.0 is fine too
Are you OK with v in the beginning?

@floreks
Copy link
Member

floreks commented Feb 3, 2016

Fine by me

@lavvy
Copy link

lavvy commented Feb 3, 2016

Cool
On Feb 3, 2016 1:34 PM, "Sebastian Florek" notifications@github.com wrote:

Fine by me


Reply to this email directly or view it on GitHub
#328 (comment).

I propose that we start with version 0.1 and use semantic versioning.
@bryk
Copy link
Contributor Author

bryk commented Feb 3, 2016

Updated. PTAL.

@floreks
Copy link
Member

floreks commented Feb 3, 2016

LGTM

bryk added a commit that referenced this pull request Feb 3, 2016
Set first release version and fix gulp release pipeline
@bryk bryk merged commit 04453c0 into kubernetes:master Feb 3, 2016
@bryk bryk deleted the release-2-jan branch February 3, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants