-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add external endpoint for cluster IP services #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is
|
I like the size and scope of this PR, btw. "one thing at a time". |
I can't see a link...are you sure it is working? |
Wasn't this supposed to return localhost addresses only for nodeports/loadbalancers that fail to resolve any other meaningful address. Am I right? CC @cheld |
Yes exactly..I will try it once again. |
Okay, so this need to be refactored. I'll let you know when it will be ready for review. |
I tested for local cluster. It works exactly as intended. I have not tested on vagrant or gce, yet. |
LGTM |
@bryk PTAL |
LGTM :) |
Add external endpoint for cluster IP services
Fixed kubernetes#366. Added check if AK/SK exists when user accesses multi-cloud functions
Connected to discussion from pull request #320 and issue #313:
I've set
localhost:targetport
as a external endpoint for cluster IP services. I've used target port instead of nodeport, because it was always 0 during tests. Is it correct?Please take a look and say your opinion about it. Change is not big, so I can quickly adapt it (for example use node port instead of target port).
CC @cheld @bryk