Skip to content

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 19, 2016

I've updated:

  • Google Closure Compiler to version 20160208.1.0
  • Angular to version 1.5.0
  • Angular-animate to version 1.5.0
  • Angular-aria to version 1.5.0
  • Angular messages to version 1.5.0
  • Angular-resource to version 1.5.0
  • Angular-sanitize to version 1.5.0
  • Angular-mocks to version 1.5.0

Deprecated compiler flags were changed to newly added in favour of google/closure-compiler#1319:

  • manage_closure_compiler to dependency_mode
  • closure_entry_point to entry_point

Additionally some compiler checks had to be turned off because newest google-closure-library has some JSDoc issues and compiler complains about that.

IMPORTANT

It's best to remove current bower_components and do a clean install:
rm -rf bower_components/ && bower install
npm install should be enough to update closure compiler

@maciaszczykm @batikanu @digitalfishpond @cheld @taimir

@bryk
Copy link
Contributor

bryk commented Feb 19, 2016

LGTM. Can you CC all folks from your team here so that they know about the update?

@codecov-io
Copy link

Current coverage is 81.62%

Merging #404 into master will not affect coverage as of 7c03f61

@@            master    #404   diff @@
======================================
  Files           75      75       
  Stmts          615     615       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            502     502       
  Partial          0       0       
  Missed         113     113       

Review entire Coverage Diff as of 7c03f61

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member Author

floreks commented Feb 19, 2016

LGTM. Can you CC all folks from your team here so that they know about the update?

Sure.

bryk added a commit that referenced this pull request Feb 19, 2016
Angular and Google Closure Compiler update
@bryk bryk merged commit 37cad13 into kubernetes:master Feb 19, 2016
@bryk bryk deleted the angular-gcc-update branch February 19, 2016 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants