-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add FBT for logs #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FBT for logs #513
Conversation
Current coverage is
|
@cheld Could you take a look? |
| Concurrency | delete replication controller | edit pod count | | | | | | | | | ||
| Factor | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | Comment | | ||
|-------------------------------|-----------------|---------------------|--------------|-------------|------|-----------------|---|---|---------| | ||
| Screen size | normal | mobile | narrow | middle size | wide | active resizing | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RC list page, the layouting is a very important feature. That's why we should test screen sizes in very detail. I don't see it for logs page. I would leave it to the general factor 'screen size'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move it to general factor, but I thought, that general factors should be the same for all sheets. Regarding screen size factor I think it's important due to toolbar and it's behaviour on smaller screens. I agree, that there are many cases for this factor, but this test should be quick anyways.
Think about the following factors:
That's all I could think off. Please investigate and add more factors. |
I've added logs size, pod and container name factors. Concurrency won't have any impact, because we do not refresh view asynchronously. Regarding log lines length, we do not have any impact on it, and I think when we will be testing logs with large size (1GB), then we'll see all kinds of logs line length. PTAL |
About concurrency: Steps:
=> Internal Server Error (500) pods "frontend-iei5o" not found Do we consider this as a bug? Maybe ok for the moment. I am ok with skipping concurrency. |
LGTM, I merge as I do not expect further comments. |
Changelog for Hawaii release
Fixes #503 issue.
This change is