Skip to content

Conversation

maciaszczykm
Copy link
Member

Please take a look at discussion in #434 issue. Fixes #434 issue.


This change is Review on Reviewable

@codecov-io
Copy link

Current coverage is 85.99%

Merging #516 into master will not affect coverage as of 9e10a3d

@@            master    #516   diff @@
======================================
  Files           95      95       
  Stmts          814     814       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            700     700       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 9e10a3d

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 10, 2016

Small comment. Overall LGTM


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/app/frontend/replicationcontrollerdetail/updatereplicas.html, line 30 [r1] (raw file):
Add kd-validate="integer" here as for the pods input field on deploy page. Floating point number can be used now and there is error in console as we can not have 12.5 pods.


src/app/frontend/replicationcontrollerdetail/updatereplicas.html, line 31 [r1] (raw file):
Remove space at the end


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

Review status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions.


src/app/frontend/replicationcontrollerdetail/updatereplicas.html, line 30 [r1] (raw file):
Done.


src/app/frontend/replicationcontrollerdetail/updatereplicas.html, line 31 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@floreks
Copy link
Member

floreks commented Mar 11, 2016

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

maciaszczykm added a commit that referenced this pull request Mar 11, 2016
@maciaszczykm maciaszczykm merged commit fed0c9f into kubernetes:master Mar 11, 2016
@maciaszczykm maciaszczykm deleted the pods-count-bug branch March 11, 2016 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants