Skip to content

Conversation

maciaszczykm
Copy link
Member

Improved tabbing on deploy page by adding tabindex="-1" attributes. It made Learn more links not accessible via TAB button. It's preffered solution as it was described on https://www.paciellogroup.com/blog/2014/08/using-the-tabindex-attribute/.

Fixes #525.


This change is Review on Reviewable

@codecov-io
Copy link

Current coverage is 85.99%

Merging #526 into master will not affect coverage as of 44f1857

@@            master    #526   diff @@
======================================
  Files           95      95       
  Stmts          814     814       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            700     700       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 44f1857

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 14, 2016

:lgtm:


Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

floreks pushed a commit that referenced this pull request Mar 14, 2016
@floreks floreks merged commit 1ff3fa9 into kubernetes:master Mar 14, 2016
@maciaszczykm maciaszczykm deleted the tabbing-fix branch March 14, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants