Skip to content

Conversation

maciaszczykm
Copy link
Member

Fixes #573, check it out for more information.

CC @bryk @kwodzynski


This change is Reviewable

@maciaszczykm maciaszczykm added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Mar 29, 2016
@codecov-io
Copy link

Current coverage is 86.89%

Merging #586 into master will not affect coverage as of 0933622

@@            master    #586   diff @@
======================================
  Files          102     102       
  Stmts          870     870       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            756     756       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 0933622

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 30, 2016

1 small comment. Otherwise :lgtm:.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/app/backend/replicationcontrollerdetail.go, line 181 [r1] (raw file):
Our StartTime was made a pointer because pod.Status.StartTime was a pointer. I think we can make it exact and use pod.CreationTimestamp here. Just to be consistent.


Comments from the review on Reviewable.io

@floreks
Copy link
Member

floreks commented Mar 30, 2016

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/app/backend/replicationcontrollerdetail.go, line 181 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@maciaszczykm maciaszczykm merged commit 9ae1dab into kubernetes:master Mar 30, 2016
@maciaszczykm maciaszczykm deleted the pod-start-time-fix branch March 30, 2016 09:20
anvithks added a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
…e-dashboard

Removing for bucket field in ceph backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants