Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar corrections for creating-sample-user #6613

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

vvdaal
Copy link
Contributor

@vvdaal vvdaal commented Nov 5, 2021

Fixed grammar for creating-sample-user

Fixed grammar for creating-sample-user
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @vvdaal!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #6613 (f928ef2) into master (15300bd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6613      +/-   ##
==========================================
- Coverage   42.59%   42.58%   -0.01%     
==========================================
  Files         217      217              
  Lines       10650    10650              
  Branches      177      177              
==========================================
- Hits         4536     4535       -1     
- Misses       5813     5814       +1     
  Partials      301      301              

@vvdaal
Copy link
Contributor Author

vvdaal commented Nov 8, 2021

/assign @jeefy

I think the E2E test failing is expected but you might want to check that out.

@shu-mutou
Copy link
Contributor

Sorry for late. E2E now available, but no significant problem for docs. So I'd merge this.

@shu-mutou shu-mutou merged commit bf05c05 into kubernetes:master Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinashupadhya99, shu-mutou, vvdaal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@vvdaal vvdaal deleted the patch-1 branch December 7, 2021 21:31
@vvdaal vvdaal restored the patch-1 branch December 7, 2021 21:31
@vvdaal vvdaal deleted the patch-1 branch December 7, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants