Skip to content

Fix generic delete: make it work with extension resources #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2016
Merged

Fix generic delete: make it work with extension resources #756

merged 1 commit into from
May 20, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented May 20, 2016 •
edited
Loading

Previously it couldn't delete, e.g., a replica set.

This change is Reviewable

@bryk
Fix generic delete: make it work with extension resources
c50817f 
Previously it couldn't delete, e.g., a replica set.
@bryk
Copy link
Contributor Author

bryk commented May 20, 2016

@floreks Can you review?

@floreks
Copy link
Member

floreks commented May 20, 2016

:lgtm:

Previously, bryk (Piotr Bryk) wrote…

@floreks Can you review?

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@floreks floreks merged commit 79ad051 into kubernetes:master May 20, 2016
@bryk bryk deleted the fix-verber branch May 20, 2016 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@floreks floreks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryk @floreks @googlebot