Skip to content

Conversation

floreks
Copy link
Member

@floreks floreks commented May 31, 2016

As we want to support PetSets, kubernetes client dependencies need to be updated. There are issues with godep because our import path is different than our backend code path and I couldn't find a way to update them using godep, so I've updated it manually.

Checkout and test it please as also our code needed some changes.

If anyone knows a way to update everything correctly with godeps, it would be great.

Go tests need to be fixed. Do not merge.


This change is Reviewable

@bryk
Copy link
Contributor

bryk commented May 31, 2016

Reviewed 11 of 2008 files at r1.
Review status: 11 of 1919 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

codecov-io commented May 31, 2016

Current coverage is 95.20%

Merging #785 into master will increase coverage by 0.42%

  1. File ...ereader_directive.js (not in diff) was modified. more
    • Misses -6
    • Partials 0
    • Hits +6
@@             master       #785   diff @@
==========================================
  Files           177        177          
  Lines          1397       1397          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1324       1330     +6   
+ Misses           73         67     -6   
  Partials          0          0          

Powered by Codecov. Last updated by 11ad639...de97d43

@floreks
Copy link
Member Author

floreks commented May 31, 2016

Tests fixed. Let's wait for travis.

@bryk
Copy link
Contributor

bryk commented May 31, 2016

LGTM

@floreks floreks merged commit 7bb43f8 into kubernetes:master May 31, 2016
@floreks floreks deleted the update-go-deps branch May 31, 2016 13:14
@bryk
Copy link
Contributor

bryk commented May 31, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants