-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add Job resource backend #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 94.86%
@@ master #792 diff @@
==========================================
Files 197 197
Lines 1596 1596
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1508 1514 +6
+ Misses 88 82 -6
Partials 0 0
|
Looks nice. Add more tests and we're ready to go
|
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. src/app/backend/resource/common/types.go, line 117 [r2] (raw file):
|
Review status: 8 of 9 files reviewed at latest revision, 3 unresolved discussions. src/app/backend/resource/common/types.go, line 117 [r2] (raw file):
|
Review status: 7 of 9 files reviewed at latest revision, 3 unresolved discussions. src/app/backend/resource/common/types.go, line 117 [r2] (raw file):
|
Reviewed 1 of 2 files at r3. src/app/backend/resource/common/types.go, line 117 [r2] (raw file):
|
We established with @maciaszczykm that I will merge first and then he can use new code in this PR. |
Perfect. Fix travis and merge |
Added tests. Fixed JS & Go files formatting (it seems people still forget about it). |
Added Job resource support in the backend.
Connected to #788.
This change is