Skip to content

Conversation

taimir
Copy link
Contributor

@taimir taimir commented Jun 2, 2016

One more localization batch. @bryk PTAL


This change is Reviewable

@codecov-io
Copy link

Current coverage is 94.86%

Merging #802 into master will increase coverage by 0.29%

  1. File ...ereader_directive.js (not in diff) was modified. more
    • Misses -6
    • Partials 0
    • Hits +6
@@             master       #802   diff @@
==========================================
  Files           187        187          
  Lines          1466       1478    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1386       1402    +16   
+ Misses           80         76     -4   
  Partials          0          0          

Powered by Codecov. Last updated by 393a406...77d6882

@bryk
Copy link
Contributor

bryk commented Jun 2, 2016

:lgtm:

Previously, codecov-io wrote…

[Current coverage][cc-pull] is 94.86%

Merging [#802][cc-pull] into [master][cc-base-branch] will increase coverage by 0.29%

  1. File ...ereader_directive.js (not in diff) was modified. more
    • Misses -6
    • Partials 0
    • Hits +6
@@             master       #802   diff @@
==========================================
  Files           187        187          
  Lines          1466       1478    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1386       1402    +16   
+ Misses           80         76     -4   
  Partials          0          0          

Powered by Codecov. Last updated by [393a406...77d6882][cc-compare]
[cc-base-branch]: https://codecov.io/gh/kubernetes/dashboard/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/kubernetes/dashboard/compare/393a406f5483583f29ec6d8fe2ff0be321664d34...77d688270a6de21544fbe026b8f744f8d713c995
[cc-pull]: https://codecov.io/gh/kubernetes/dashboard/pull/802?src=pr


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bryk bryk merged commit 1cde4d2 into kubernetes:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants