Skip to content

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Jun 10, 2016

Fixes #771


This change is Reviewable

@bryk bryk added this to the v1.1 milestone Jun 10, 2016
@bryk
Copy link
Contributor Author

bryk commented Jun 10, 2016

@maciaszczykm Can you review?

@maciaszczykm
Copy link
Member

When picking different container from same pod namespace selector is reset to namespace not selected. It should be fixed.

Other than that :lgtm:

Previously, bryk (Piotr Bryk) wrote…

@maciaszczykm Can you review?


Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bryk
Copy link
Contributor Author

bryk commented Jun 10, 2016

Oh yeah, it was hard to notice :) Fixed. Will merge soon.

Previously, maciaszczykm (Marcin Maciaszczyk) wrote…

When picking different container from same pod namespace selector is reset to namespace not selected. It should be fixed.

Other than that :lgtm:


Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

Current coverage is 93.32%

Merging #875 into master will decrease coverage by 0.29%

  1. 2 files in src/app/frontend were modified. more
    • Misses +11
    • Hits -11
  2. File ...ereader_directive.js (not in diff) was modified. more
    • Misses -6
    • Partials 0
    • Hits +6
@@             master       #875   diff @@
==========================================
  Files           223        223          
  Lines          1882       1874     -8   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1762       1749    -13   
- Misses          120        125     +5   
  Partials          0          0          

Powered by Codecov. Last updated by 5d5e59e...812f19a

@bryk bryk merged commit fad96e0 into kubernetes:master Jun 10, 2016
@bryk bryk deleted the pods-view branch June 10, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants