Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deployments to correctly indicate they are failing to deploy #122

Closed
smarterclayton opened this issue Oct 9, 2016 · 8 comments
Closed
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 9, 2016

Feature Description

  • One-line feature description (can be used as a release note): Allow deployments to correctly indicate they are failing to deploy
  • Primary contact (assignee): @Kargakis
  • Responsible SIGs: @kubernetes/sig-apps-proposals
  • Design proposal link: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#failed-deployment
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @janetkuo @smarterclayton
  • Approver (likely from SIG/area to which feature belongs): @smarterclayton
  • Feature target (which target equals to which milestone):
    • Beta release target (1.5)
    • Stable release target (1.6)
@0xmichalis
Copy link

@kubernetes/docs kubernetes/website#1699 is the docs PR for this.

@idvoretskyi
Copy link
Member

@smarterclayton can you confirm that this item targets stable in 1.6?

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.5 Dec 13, 2016
@idvoretskyi idvoretskyi added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Dec 15, 2016
@idvoretskyi idvoretskyi modified the milestones: v1.6, next-milestone Dec 15, 2016
@0xmichalis
Copy link

Docs at http://kubernetes.io/docs/user-guide/deployments/#deployment-status

@idvoretskyi
Copy link
Member

@0xmichalis
Copy link

0xmichalis commented Mar 7, 2017 via email

@devin-donnelly
Copy link

@idvoretskyi , @Kargakis , are any changes needed for the documentation for 1.6?

@0xmichalis
Copy link

@devin-donnelly no, everything that needs to be doc'ed should already be.

@janetkuo
Copy link
Member

Closing, as this is done

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
…l_private_clusters

Azure: Internal/Private clusters enhancement doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

5 participants