Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portworx file in-tree to CSI driver migration #2589

Open
2 of 8 tasks
trierra opened this issue Mar 31, 2021 · 70 comments
Open
2 of 8 tasks

Portworx file in-tree to CSI driver migration #2589

trierra opened this issue Mar 31, 2021 · 70 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@trierra
Copy link
Contributor

trierra commented Mar 31, 2021

Enhancement Description

Parent enhancement: #625

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 31, 2021
@trierra
Copy link
Contributor Author

trierra commented Mar 31, 2021

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 31, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021
@trierra
Copy link
Contributor Author

trierra commented Jun 29, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021
@SergeyKanzhelev
Copy link
Member

was this enhancement approved for 1.22?

@trierra
Copy link
Contributor Author

trierra commented Jul 8, 2021 via email

@SergeyKanzhelev
Copy link
Member

I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone. I'm confused.

@trierra
Copy link
Contributor Author

trierra commented Jul 8, 2021 via email

@trierra
Copy link
Contributor Author

trierra commented Jul 8, 2021

oh, I see what you mean. Apparently, it's not approved.

@SergeyKanzhelev
Copy link
Member

I was told KEP is not needed,

It may not be. Change seems to be quite straightforward and likely already covered with some other KEP. Either way the code freeze for 1.22 is in 40 minutes. There is still some work left on the PR

@salaxander
Copy link
Contributor

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
@salaxander salaxander added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 31, 2021
@lauralorenz
Copy link
Contributor

Hi @trierra! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09.

It looks like the proposal was written using the design proposal format, but as of release 1.14, they now must use the KEP format which among other things includes a metadata file that is used by some release automation. In particular as of 1.19 a particular approval process called PRR review is also required which must be requested for each KEP separately.

This is all to say that though I've included the formal checklist used by enhancements team below, I think in reality you will need to migrate this into the KEP format and request a PRR reviewer for us to accept it into a milestone.

I also notice from the OP and prior comments that there is a parent enhancement which is in KEP format. You may wish to close this enhancements issue in favor of that one, *IF* that KEP is the way that your SIG is targeting milestones and communicating with enhancements team for this feature. (I didn't read the proposals in detail so apologies if that is wildly incorrect.)

Thanks!!

--

Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

@msau42
Copy link
Member

msau42 commented Sep 8, 2021

@lauralorenz This is the KEP that we're using to track all csi migration implementations: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The design and test plan is the same for each cloud provider, the only difference is that each cloud provider has its own feature gate and implementation and own release timeline.

@Jiawei0227
Copy link
Contributor

Jiawei0227 commented Sep 8, 2021

A dedicated KEP for this is out for review: #2964

@lauralorenz
Copy link
Contributor

Thanks everyone! Between comments here, comments on the new KEP PR, and the discussion in Slack in #sig-release, just confirming from my side that the new PR #2964 meets the criteria for enhancements freeze (using latest KEP template, set as implementable, inherits its parent's filled out test plan section, inherits its parent's up to date graduation criteria, and has a PRR review file artifact matching this enhancement issue number) so as long as it is merged by the deadline tonight at 11:59pm PST we are good to go!

@salaxander
Copy link
Contributor

Hi, 1.23 Enhancements Lead here 👋. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP is merged into k/enhancements repo with up to date latest milestone and stage.
  • KEP status is marked as implementable.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.23 milestone Sep 10, 2021
@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 10, 2021
@xing-yang
Copy link
Contributor

Thanks @salaxander! We'll be filing an exception soon.
CC @Jiawei0227 @msau42

@ramrodo
Copy link
Member

ramrodo commented Sep 22, 2021

Hi @trierra 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 13, 2023
@bsdnet
Copy link

bsdnet commented Mar 20, 2023

What's the plan to remove Portworx in-tree driver? @msau42

@msau42
Copy link
Member

msau42 commented Mar 20, 2023

The earliest possible best case schedule would be:

  • Beta on by default (1.28)
  • GA (1.29)
  • Removal 2 releases after GA (1.31)

@trierra can you comment on your plans for feature promotion?

@bsdnet
Copy link

bsdnet commented Mar 31, 2023

Thank you.

@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@xing-yang xing-yang modified the milestones: v1.25, v1.30 Jan 17, 2024
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 17, 2024
@xing-yang
Copy link
Contributor

/assign @ggriffiths

@salehsedghpour
Copy link
Contributor

Hello @ggriffiths 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the README.md file with the latest template.
  • The latest-milestone and stage should be updated to v1.30 and stable in the kep.yaml file respectively. Moreover, please update the milestone part adding the required info.
  • The production readiness review should be completed and updated with the information for the targeting stage stable.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@ggriffiths
Copy link
Member

Hi, we are targeting this for k8s 1.30.

Beta release target (x.y): 1.30 (on-by-default)

I'll have the new owner for this start working on the KEP changes. Thanks @salehsedghpour

@salehsedghpour
Copy link
Contributor

Thanks for clarification @ggriffiths. With all the info, we would just need to update the following:

  • Update the README.md file with the latest template.
  • The latest-milestone should be updated to v1.30 in the kep.yaml file. Moreover, please update the milestone part adding the required info.
  • The production readiness review should be completed and updated with the information for the targeting stage beta (if there is a new approver).

@ggriffiths
Copy link
Member

/assign @lpabon

@lpabon
Copy link
Contributor

lpabon commented Jan 24, 2024

Hi all, FYI I'll be taking over the updates.

@salehsedghpour
Copy link
Contributor

Hi @lpabon, I was wondering if we (1.30 Enhancement team) should track this Enhancement for 1.30, as the recent PR #4467 is targeting 1.31.

@xing-yang xing-yang modified the milestones: v1.30, v1.31 Feb 2, 2024
@xing-yang xing-yang removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@xing-yang
Copy link
Contributor

Hi @salehsedghpour, @lpabon asks to target 1.31 instead. I've removed it from 1.30. Thanks.

@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Feb 9, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
@xing-yang
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label May 9, 2024
@xing-yang xing-yang added this to the v1.31 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Removed from Milestone
Status: No status
Development

No branches or pull requests