Portworx file in-tree to CSI driver migration

[trierra]

Enhancement Description

• One-line enhancement description (can be used as a release note):
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• Primary contact (assignee): @trierra
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.25 (off-by-default)
  • Beta release target (x.y): 1.31 (on-by-default)
  • Stable release target (x.y): 1.32

Parent enhancement: #625

• Alpha
  • KEP (k/enhancements) update PR(s): KEP-2589: Portworx CSI Migration #2964
  • Code (k/k) update PR(s): Csi translation portworx kubernetes#103447
  • Docs (k/website) update PR(s): CSI migration portworx in alpha state website#30445
• Beta(off-by-default)
  • KEP (k/enhancements) update PR(s): Promote Portworx CSI migration to Beta in v1.25 #3345
  • Code (k/k) update PR(s): promote the Portworx feature gate to Beta kubernetes#110411
  • Docs (k/website) update(s): Px 125 beta website#34886
• Beta(on-by-default)
  • KEP (k/enhancements) update PR(s): Promote Portworx CSI migration to Beta in 1.31 #4467
  • Code (k/k) update PR(s): Enables the Portworx in-tree driver to Portworx migration feature by default kubernetes#125016
  • Docs (k/website) update(s): update portworxVolume doc website#46506

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[trierra]

/sig storage

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[trierra]

/remove-lifecycle stale

[SergeyKanzhelev]

was this enhancement approved for 1.22?

[trierra]

it was planned to get to 1.22

…

On Wed, Jul 7, 2021 at 10:18 PM Sergey Kanzhelev ***@***.***> wrote: was this enhancement approved for 1.22? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2589 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAX3S75OZLTLP4UMEZNMWXDTWUYMFANCNFSM42DXZYOA> .

-- --------- Best regards, *Oksana Naumov* // *MTS @ CNBU*

[SergeyKanzhelev]

I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone. I'm confused.

[trierra]

Sorry for confusion, I was told KEP is not needed, I only have an open issue for that #2589

…

On Thu, Jul 8, 2021 at 10:36 AM Sergey Kanzhelev ***@***.***> wrote: I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone <https://github.com/kubernetes/enhancements/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fstorage+milestone%3Av1.22>. I'm confused. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2589 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAX3S73XEZXZGNCIJVCU3MLTWXO3JANCNFSM42DXZYOA> .

-- --------- Best regards, *Oksana Naumov* // *MTS @ CNBU*

[trierra]

oh, I see what you mean. Apparently, it's not approved.

[SergeyKanzhelev]

I was told KEP is not needed,

It may not be. Change seems to be quite straightforward and likely already covered with some other KEP. Either way the code freeze for 1.22 is in 40 minutes. There is still some work left on the PR

[salaxander]

/milestone v1.23

[lauralorenz]

Hi @trierra! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09.

It looks like the proposal was written using the design proposal format, but as of release 1.14, they now must use the KEP format which among other things includes a metadata file that is used by some release automation. In particular as of 1.19 a particular approval process called PRR review is also required which must be requested for each KEP separately.

This is all to say that though I've included the formal checklist used by enhancements team below, I think in reality you will need to migrate this into the KEP format and request a PRR reviewer for us to accept it into a milestone.

I also notice from the OP and prior comments that there is a parent enhancement which is in KEP format. You may wish to close this enhancements issue in favor of that one, *IF* that KEP is the way that your SIG is targeting milestones and communicating with enhancements team for this feature. (I didn't read the proposals in detail so apologies if that is wildly incorrect.)

Thanks!!

--

Here's where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

[msau42]

@lauralorenz This is the KEP that we're using to track all csi migration implementations: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The design and test plan is the same for each cloud provider, the only difference is that each cloud provider has its own feature gate and implementation and own release timeline.

[Jiawei0227]

A dedicated KEP for this is out for review: #2964

[lauralorenz]

Thanks everyone! Between comments here, comments on the new KEP PR, and the discussion in Slack in #sig-release, just confirming from my side that the new PR #2964 meets the criteria for enhancements freeze (using latest KEP template, set as implementable, inherits its parent's filled out test plan section, inherits its parent's up to date graduation criteria, and has a PRR review file artifact matching this enhancement issue number) so as long as it is merged by the deadline tonight at 11:59pm PST we are good to go!

[salaxander]

Hi, 1.23 Enhancements Lead here 👋. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

• KEP is merged into k/enhancements repo with up to date latest milestone and stage.
• KEP status is marked as implementable.
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

Thanks @salaxander! We'll be filing an exception soon.
CC @Jiawei0227 @msau42

[ramrodo]

Hi @trierra 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[xing-yang]

/assign @ggriffiths

[salehsedghpour]

Hello @ggriffiths 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Update the README.md file with the latest template.
• The latest-milestone and stage should be updated to v1.30 and stable in the kep.yaml file respectively. Moreover, please update the milestone part adding the required info.
• The production readiness review should be completed and updated with the information for the targeting stage stable.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

[ggriffiths]

Hi, we are targeting this for k8s 1.30.

Beta release target (x.y): 1.30 (on-by-default)

I'll have the new owner for this start working on the KEP changes. Thanks @salehsedghpour

[salehsedghpour]

Thanks for clarification @ggriffiths. With all the info, we would just need to update the following:

• Update the README.md file with the latest template.
• The latest-milestone should be updated to v1.30 in the kep.yaml file. Moreover, please update the milestone part adding the required info.
• The production readiness review should be completed and updated with the information for the targeting stage beta (if there is a new approver).

[ggriffiths]

/assign @lpabon

[lpabon]

Hi all, FYI I'll be taking over the updates.

[salehsedghpour]

Hi @lpabon, I was wondering if we (1.30 Enhancement team) should track this Enhancement for 1.30, as the recent PR #4467 is targeting 1.31.

[xing-yang]

Hi @salehsedghpour, @lpabon asks to target 1.31 instead. I've removed it from 1.30. Thanks.

[salehsedghpour]

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[mickeyboxell]

Hi @lpabon 👋 v1.31 Enhancements team here.

I wanted to check in as we approach the enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting beta (on by default) for v1.31. Please correct me if that isn't the case.

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we need to do the following:

• Please share a link to the PRR approval and if it has not yet been approved make sure to do so by the deadline mentioned above.
• Please update the issue description with the links to the PR: Promote Portworx CSI migration to Beta in 1.31 #4467

The status of this enhancement is marked as at risk for enhancement freeze. We can mark it as tracked as soon as the above changes are merged. Please make sure to get this done before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

[xing-yang]

Hi @mickeyboxell, this enhancement already got PRR approval for Beta when it moved to Beta (off-by-default) in K8s 1.24 release. See this PR:
#3187

In 1.31, we are staying in Beta while enabling the feature gate (on-by-default).

[MaryamTavakkoli]

Hello @ggriffiths and @lpabon 👋, 1.31 Docs Shadow here.
Does this enhancement work planned for 1.31 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, June 27, 2024, 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

[mickeyboxell]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[edithturn]

Hello @ggriffiths, @lpabon

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[edithturn]

Hello @ggriffiths, @lpabon

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Hi @ggriffiths , @lpabon 👋!

Just a friendly reminder: if you need to open a Feature Blog placeholder PR against the website repository, please go ahead and do so. If you have any questions or need any help, feel free to reach out! For more information about writing a blog, check out the blog contribution guidelines.

Remember, the deadline for this is coming up soon: Wednesday, July 03, 2024, at 18:00 PDT.

Thank you!!
Edith

[mickeyboxell]

Hey again @ggriffiths @lpabon 👋 Kubernetes 1.31 Enhancements team here.

Just checking in as we approach code freeze at at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

With all the implementation (code related) PRs merged as per the issue description:

• Code (k/k) update PR(s): Enables the Portworx in-tree driver to Portworx migration feature by default kubernetes#125016
• Docs (k/website) update(s): update portworxVolume doc website#46506

This enhancement is now marked as tracked for code freeze for the v1.31 Code Freeze!