Portworx file in-tree to CSI driver migration

[trierra]

Enhancement Description

• One-line enhancement description (can be used as a release note):
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• Primary contact (assignee): @trierra
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.25
  • Stable release target (x.y): 1.26

Parent enhancement: #625

• Alpha

  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

• Beta

  • KEP (k/enhancements) update PR(s): Promote Portworx CSI migration to Beta in v1.25 #3345
  • Code (k/k) update PR(s): promote the Portworx feature gate to Beta kubernetes#110411
  • Docs (k/website) update(s): Px 125 beta website#34886

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[trierra]

/sig storage

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[trierra]

/remove-lifecycle stale

[SergeyKanzhelev]

was this enhancement approved for 1.22?

[trierra]

it was planned to get to 1.22

…

On Wed, Jul 7, 2021 at 10:18 PM Sergey Kanzhelev ***@***.***> wrote: was this enhancement approved for 1.22? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2589 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAX3S75OZLTLP4UMEZNMWXDTWUYMFANCNFSM42DXZYOA> .

-- --------- Best regards, *Oksana Naumov* // *MTS @ CNBU*

[SergeyKanzhelev]

I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone. I'm confused.

[trierra]

Sorry for confusion, I was told KEP is not needed, I only have an open issue for that #2589

…

On Thu, Jul 8, 2021 at 10:36 AM Sergey Kanzhelev ***@***.***> wrote: I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone <https://github.com/kubernetes/enhancements/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fstorage+milestone%3Av1.22>. I'm confused. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2589 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAX3S73XEZXZGNCIJVCU3MLTWXO3JANCNFSM42DXZYOA> .

-- --------- Best regards, *Oksana Naumov* // *MTS @ CNBU*

[trierra]

oh, I see what you mean. Apparently, it's not approved.

[SergeyKanzhelev]

I was told KEP is not needed,

It may not be. Change seems to be quite straightforward and likely already covered with some other KEP. Either way the code freeze for 1.22 is in 40 minutes. There is still some work left on the PR

[salaxander]

/milestone v1.23

[lauralorenz]

Hi @trierra! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09.

It looks like the proposal was written using the design proposal format, but as of release 1.14, they now must use the KEP format which among other things includes a metadata file that is used by some release automation. In particular as of 1.19 a particular approval process called PRR review is also required which must be requested for each KEP separately.

This is all to say that though I've included the formal checklist used by enhancements team below, I think in reality you will need to migrate this into the KEP format and request a PRR reviewer for us to accept it into a milestone.

I also notice from the OP and prior comments that there is a parent enhancement which is in KEP format. You may wish to close this enhancements issue in favor of that one, *IF* that KEP is the way that your SIG is targeting milestones and communicating with enhancements team for this feature. (I didn't read the proposals in detail so apologies if that is wildly incorrect.)

Thanks!!

--

Here's where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

[msau42]

@lauralorenz This is the KEP that we're using to track all csi migration implementations: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The design and test plan is the same for each cloud provider, the only difference is that each cloud provider has its own feature gate and implementation and own release timeline.

[Jiawei0227]

A dedicated KEP for this is out for review: #2964

[lauralorenz]

Thanks everyone! Between comments here, comments on the new KEP PR, and the discussion in Slack in #sig-release, just confirming from my side that the new PR #2964 meets the criteria for enhancements freeze (using latest KEP template, set as implementable, inherits its parent's filled out test plan section, inherits its parent's up to date graduation criteria, and has a PRR review file artifact matching this enhancement issue number) so as long as it is merged by the deadline tonight at 11:59pm PST we are good to go!

[salaxander]

Hi, 1.23 Enhancements Lead here 👋. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

• KEP is merged into k/enhancements repo with up to date latest milestone and stage.
• KEP status is marked as implementable.
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

Thanks @salaxander! We'll be filing an exception soon.
CC @Jiawei0227 @msau42

[ramrodo]

Hi @trierra 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[trierra]

@Priyankasaggu11929 see the PR here #3428

[Priyankasaggu11929]

Thanks so much for the update, @trierra. 🙂

[krol3]

Hello @trierra 👋, 1.25 Release Docs shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

[trierra]

hi @krol3, should I branch out from master or dev-1.24? I did from master and ended up with this conflict kubernetes/website#34886

[marosset]

Hi @trierra 👋

1.25 enhancements team here. Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

It looks like with kubernetes/kubernetes#110411 this enhancement is on track for graduation to beta with the 1.25 release.

If there are any other related PRs, can you please link them to this issue and also update the initial issue description with links to all applicable PRs?

As always, we are here to help should questions come up.

Thanks!!

[krol3]

hi @krol3, should I branch out from master or dev-1.24? I did from master and ended up with this conflict kubernetes/website#34886

Hi @trierra how are you? Do you mean dev-1.25? Weekly, we keep update the dev-1.25 with the main branch. Any doubt please contact me.

[trierra]

Hi @marosset. It seems like all my PRs are merged, except this one kubernetes/website#34886 (comment)

[marosset]

Hi @marosset. It seems like all my PRs are merged, except this one kubernetes/website#34886 (comment)

Great!
Website updates aren't subject to the upcoming code-freeze deadline so this enhancement is still on track.
Thanks for updating the Issue description too!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

/reopen
/remove-lifecycle rotten

[k8s-ci-robot]

@msau42: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bsdnet]

What's the plan to remove Portworx in-tree driver? @msau42

[msau42]

The earliest possible best case schedule would be:

• Beta on by default (1.28)
• GA (1.29)
• Removal 2 releases after GA (1.31)

@trierra can you comment on your plans for feature promotion?

[bsdnet]

Thank you.