Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained SupplementalGroups control #3619

Open
18 tasks done
Tracked by #112879
everpeace opened this issue Oct 14, 2022 · 50 comments
Open
18 tasks done
Tracked by #112879

Fine-grained SupplementalGroups control #3619

everpeace opened this issue Oct 14, 2022 · 50 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@everpeace
Copy link
Contributor

everpeace commented Oct 14, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/assign
/sig node
/kind feature

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 14, 2022
@everpeace

This comment was marked as off-topic.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

@everpeace: The label(s) /remove-label sig/scheduling cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label sig/scheduling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 14, 2022
@everpeace

This comment was marked as off-topic.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 14, 2022
@everpeace everpeace changed the title SupplementalGroupsPolicy: fine grained SupplementalGroups control Fine grained SupplementalGroups control Oct 14, 2022
@everpeace everpeace changed the title Fine grained SupplementalGroups control Fine-grained SupplementalGroups control Oct 17, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2023
@everpeace
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.27

let's see if we can start it in 1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 2, 2023
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 3, 2023
@npolshakova
Copy link

Hello @everpeace 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #3620 will address most of these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Feb 9, 2023

@npolshakova, kep yaml has correct values for stage, milestone, etc:

status: implementable
creation-date: 2022-10-14
reviewers:
- "@thockin"
- "@mrunalp"
- "@SergeyKanzhelev"
approvers:
- "@mrunalp"
see-also: []
replaces: []
# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.27"
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.27"

This KEP updates to the latest template and covers testing section: #3862

PRR review completed:

# The KEP must have an approver from the
# "prod-readiness-approvers" group
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
kep-number: 3619
alpha:
approver: "@johnbelamaric"

So once #3862 is merged, this KEP is ready for the milestone

@npolshakova
Copy link

Great! Looks like #3862 went in so this enhancement as tracked for v1.27.
Thanks!

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2023
@everpeace
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2024
@everpeace
Copy link
Contributor Author

everpeace commented May 21, 2024

@kubernetes/sig-node-leads Recently, I have been working (rebooted) on this KEP actively to target v1.31.

Could we get this KEP opt-in for v1.31? WDYT?

@thockin thockin added this to the v1.31 milestone May 21, 2024
@thockin
Copy link
Member

thockin commented May 21, 2024

@mrunalp or @dchen1107 or delegate - are you OK to lead opt-in ?

@mrunalp
Copy link
Contributor

mrunalp commented May 28, 2024

/label lead-opted-in

@ArkaSaha30
Copy link
Member

ArkaSaha30 commented Jun 4, 2024

Hello @everpeace 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

All the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@LaurentGoderre
Copy link
Member

@everpeace Docs team here. Can you create a PR for the documentation for this enhancement?

@rashansmith
Copy link

Hi @everpeace,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@everpeace
Copy link
Contributor Author

everpeace commented Jun 22, 2024

@LaurentGoderre

Docs team here. Can you create a PR for the documentation for this enhancement?

Thanks, I opened a draft PR for this KEP: kubernetes/website#46920

@everpeace
Copy link
Contributor Author

@rashansmith

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Thanks, I'm happy to write a blog for this KEP. I opened a placeholder PR: kubernetes/website#46921

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@ArkaSaha30
Copy link
Member

Hey again @everpeace 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Regarding this enhancement, it appears that there are currently 2 open PRs in the k/k repository out of which one is merged and the other is up for review.

For this KEP, we would need to do the following:

  • Ensure the remaining PR is prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is currently marked as at risk for code freeze.

@everpeace
Copy link
Contributor Author

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.
Regarding this enhancement, it appears that there are currently 2 open PRs in the k/k repository out of which one is kubernetes/kubernetes#117842 and the other is up for kubernetes/kubernetes#125470 (review) review).

@thockin @mrunalp @SergeyKanzhelev (as KEP reviwers/approvers)
cc/ @haircommander (as an active reviwer on this KEP PRs)

I apologize for bothering you again. As you may already be aware, my last k/k PR kubernetes/kubernetes#125470 (review) for this KEP is ready for review. I would be very grateful if this KEP could reach alpha in v1.31🙇.

@ArkaSaha30
Copy link
Member

Hey again @everpeace 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment #3619 (comment) still need to be completed. The following PR as per the description still needs to be merged:

If you anticipate missing code freeze, you can file an exception request in advance.

@thockin
Copy link
Member

thockin commented Jul 22, 2024

Whether the containerd PR is merged or not shouldn't matter here - their release train is async to ours anyway. @ArkaSaha30 tell me if you disagree?

@ArkaSaha30
Copy link
Member

Whether the containerd PR is merged or not shouldn't matter here - their release train is async to ours anyway.

Yes, agree. Thank you for the clarification.
Since the code PRs to k/k are in place and merged, I am marking this enhancement as tracked for code freeze for the 1.31 Code Freeze!

@everpeace
Copy link
Contributor Author

everpeace commented Jul 22, 2024

Thanks, I updated this Issue's description to make containerd/CRI-O PRs optional.

updated: all the optional PR are merged now 👍 The remaining part is just doc and blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Removed From Milestone
Status: Removed from Milestone
Status: Tracked for Doc Freeze
Development

No branches or pull requests