Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for online resizing of PVs #531

Open
mlmhl opened this issue Dec 20, 2017 · 53 comments

Comments

Projects
None yet
@mlmhl
Copy link

commented Dec 20, 2017

Feature Description

@mlmhl

This comment has been minimized.

Copy link
Author

commented Dec 20, 2017

This is a sub feature of this feature.

@idvoretskyi

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

/assign @mlmhl

@idvoretskyi

This comment has been minimized.

Copy link
Member

commented Jan 22, 2018

/sig storage

@Bradamant3

This comment has been minimized.

Copy link
Member

commented Mar 2, 2018

@mlmhl doc PR, please? also please update the 1.10 feature tracking spreadsheet
It looks as though there are several related features going into this release; I'm tracking them for docs purposes per the spreadsheet. lmk if something else would work better. Also if one doc PR covers multiple issues, if you tag the issues in the doc PR, that will help. Thanks!

@Bradamant3

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

@mlmhl docs ping ^^
/cc @idvoretskyi

@gnufied

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

This feature did make make into 1.10 milestone. Please drop this from the list.

@justaugustus

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

@mlmhl @gnufied
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@mlmhl

This comment has been minimized.

Copy link
Author

commented Apr 17, 2018

@justaugustus Yeah, we are working on this feature now, the doc PR and code PR are both posted.
The Milestone and Labels are already updated, are these correct?

@justaugustus

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

@mlmhl looks good. Just wanted to confirm before committing this to the 1.11 Features list. Thanks again!

@mistyhacks

This comment has been minimized.

Copy link
Member

commented May 24, 2018

@mlmhl please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@mlmhl

This comment has been minimized.

Copy link
Author

commented May 25, 2018

@mistyhacks done.

@mistyhacks

This comment has been minimized.

Copy link
Member

commented May 25, 2018

Thanks for marking that it needs docs. I was not able to find the placeholder PR in order to put it in the 1.11 milestone. Can you point me to it?

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 31, 2018

Kubernetes Submit Queue
Merge pull request #62460 from mlmhl/volume-online-resize
Automatic merge from submit-queue (batch tested with PRs 62460, 64480, 63774, 64540, 64337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Implement kubelet side online file system resize for volume

**What this PR does / why we need it**:

Implement kubelet side online file system resize.

xref - [kubernetes/feature#531](kubernetes/enhancements#531)
proposal - [kubernetes/community#1535](kubernetes/community#1535)

**Release note**:

```release-note
Implement kubelet side online file system resizing
```
@justaugustus

This comment has been minimized.

Copy link
Member

commented Jun 2, 2018

@mlmhl -- this feature has been moved to the Milestone risks sheet within the 1.11 Features tracking spreadsheet.

Please update the line item for this feature on the Milestone risks sheet ASAP AND ping myself and @idvoretskyi, so we can assess the feature status or we will need to officially remove it from the milestone.

@claurence

This comment has been minimized.

Copy link

commented Jan 30, 2019

@mlmhl since theKEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019

@claurence claurence added tracked/no and removed tracked/yes labels Jan 30, 2019

@wongma7

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

@claurence there was a PR open here. #737. does a kep need to be merged or just open. I cannot find where it says that a KEP needs to be merged, only that an issue must exist (this one): https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze

@claurence

This comment has been minimized.

Copy link

commented Jan 30, 2019

@wongma7 KEP needs to be merged and implementable - apologies we need to update our documentation to reflect that

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Hello @wongma7 @mlmhl , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. KEP needs to be merged to be promoted

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@gnufied

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

This feature is going beta in 1.15

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 24, 2019

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@gnufied @wongma7 @mlmhl, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. I do not see any KEPs listed here. Community Proposals are deprecated and a KEP needs to be created. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@gnufied @wongma7 @mlmhl I apologize, I see this 20190125-online-growing-persistent-volume-size. I will add this to the original post so it's not buried.

@simplytunde

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Hey @mlmhl Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@simplytunde

This comment has been minimized.

Copy link
Member

commented May 27, 2019

@gnufied @mlmhl @wongma7 The placeholder PR is due Thursday May 30th.

@kacole2

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Hi @gnufied @mlmhl @wongma7 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@kacole2

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Hi @gnufied @mlmhl @wongma7, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@gnufied

This comment has been minimized.

Copy link
Member

commented May 30, 2019

The correct link for code PR is kubernetes/kubernetes#77755 . I will open docs PR soonish.

@gnufied

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Placeholder docs PR - kubernetes/website#14643

@kacole2

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Hi @mlmhl @gnufied , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kacole2 kacole2 removed this from the v1.15 milestone Jul 15, 2019

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.