Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for online resizing of PVs #531

Open
mlmhl opened this Issue Dec 20, 2017 · 42 comments

Comments

Projects
None yet
@mlmhl
Copy link

mlmhl commented Dec 20, 2017

Feature Description

  • Allow PVs to be resized without having to terminate pods and unmount volume first.
  • Primary contact (assignee): @mlmhl
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): kubernetes/community#1535
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers: @saad-ali @gnufied
  • Approver (likely from SIG/area to which feature belongs): @jsafrane
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.11
    • Beta release target (x.y): 1.12
    • Stable release target (x.y): 1.13?
@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Dec 20, 2017

This is a sub feature of this feature.

@idvoretskyi

This comment has been minimized.

Copy link
Member

idvoretskyi commented Jan 22, 2018

/assign @mlmhl

@idvoretskyi

This comment has been minimized.

Copy link
Member

idvoretskyi commented Jan 22, 2018

/sig storage

@Bradamant3

This comment has been minimized.

Copy link
Member

Bradamant3 commented Mar 2, 2018

@mlmhl doc PR, please? also please update the 1.10 feature tracking spreadsheet
It looks as though there are several related features going into this release; I'm tracking them for docs purposes per the spreadsheet. lmk if something else would work better. Also if one doc PR covers multiple issues, if you tag the issues in the doc PR, that will help. Thanks!

@Bradamant3

This comment has been minimized.

Copy link
Member

Bradamant3 commented Mar 6, 2018

@mlmhl docs ping ^^
/cc @idvoretskyi

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Mar 6, 2018

This feature did make make into 1.10 milestone. Please drop this from the list.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@mlmhl @gnufied
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Apr 17, 2018

@justaugustus Yeah, we are working on this feature now, the doc PR and code PR are both posted.
The Milestone and Labels are already updated, are these correct?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@mlmhl looks good. Just wanted to confirm before committing this to the 1.11 Features list. Thanks again!

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented May 24, 2018

@mlmhl please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented May 25, 2018

@mistyhacks done.

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented May 25, 2018

Thanks for marking that it needs docs. I was not able to find the placeholder PR in order to put it in the 1.11 milestone. Can you point me to it?

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 31, 2018

Kubernetes Submit Queue
Merge pull request #62460 from mlmhl/volume-online-resize
Automatic merge from submit-queue (batch tested with PRs 62460, 64480, 63774, 64540, 64337). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Implement kubelet side online file system resize for volume

**What this PR does / why we need it**:

Implement kubelet side online file system resize.

xref - [kubernetes/feature#531](kubernetes/enhancements#531)
proposal - [kubernetes/community#1535](kubernetes/community#1535)

**Release note**:

```release-note
Implement kubelet side online file system resizing
```
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 2, 2018

@mlmhl -- this feature has been moved to the Milestone risks sheet within the 1.11 Features tracking spreadsheet.

Please update the line item for this feature on the Milestone risks sheet ASAP AND ping myself and @idvoretskyi, so we can assess the feature status or we will need to officially remove it from the milestone.

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 8, 2018

Hi @mlmhl @gnufied
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@kacole2 kacole2 added the tracked/no label Oct 8, 2018

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Oct 9, 2018

@kacole2 Yeah, we intend to move this enhancement to beta in 1.13, but I'm not sure what I need to do, could you help to point it out?

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 9, 2018

@mlmhl i'll take care of the labels. you take care of the code and docs. sound like a plan? ;)
/milestone v1.13

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Oct 10, 2018

Thanks @kacole2 ! The doc and code PR are as shown below, is this the right way?

doc: kubernetes/website#10574
code: kubernetes/kubernetes#67608

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 10, 2018

@mlmhl thats perfect. that will make wrangling much easier going forward.

@guineveresaenger

This comment has been minimized.

Copy link

guineveresaenger commented Nov 5, 2018

@wongma7 @mlmhl @gnufied I'm Enhancements Shadow for 1.13. Could you please update the release team with the likelihood of this enhancement making the 1.13 release?

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

@wongma7

This comment has been minimized.

Copy link

wongma7 commented Nov 9, 2018

@guineveresaenger update, after the sig-storage meeting yesterday, decision was made to delay this alpha->beta promotion another release because there is some concern a bug similar to one that was discovered recently could affect this feature (cc @gnufied @mlmhl )

@kacole2 kacole2 modified the milestones: v1.13, v1.14 Nov 11, 2018

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Nov 11, 2018

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 16, 2019

@mlmhl Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Jan 17, 2019

@claurence Yeah, we plan to improve this feature to beta in 1.14, the doc PR is here: kubernetes/website#10574.

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 17, 2019

@mlmhl thanks! Does this issues have a KEP? We want all issues in the 1.14 release to have a KEP associated with them. Thanks

@mlmhl

This comment has been minimized.

Copy link
Author

mlmhl commented Jan 18, 2019

Yeah, we have a proposal PR here: kubernetes/community#1535, but I am not sure if it is in order.

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@mlmhl since theKEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019

@claurence claurence added tracked/no and removed tracked/yes labels Jan 30, 2019

@wongma7

This comment has been minimized.

Copy link

wongma7 commented Jan 30, 2019

@claurence there was a PR open here. #737. does a kep need to be merged or just open. I cannot find where it says that a KEP needs to be merged, only that an issue must exist (this one): https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@wongma7 KEP needs to be merged and implementable - apologies we need to update our documentation to reflect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.