Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes CSI topology support #557

Open
verult opened this Issue Apr 12, 2018 · 34 comments

Comments

@verult
Copy link
Contributor

verult commented Apr 12, 2018

Feature Description

  • One-line feature description (can be used as a release note): Kubernetes CSI topology support
  • Primary contact (assignee): @verult @vladimirvivien
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo): kubernetes/community#2034
  • Link to e2e and/or unit tests:
  • Reviewer(s): @msau42 @saad-ali
  • Approver (likely from SIG/area to which feature belongs): @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.14
    • Stable release target (x.y) 1.15

@jingxu97 jingxu97 added this to the v1.11 milestone Apr 12, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

@mikedanese -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Jun 4, 2018

This feature did not make it in to 1.11, punting to 1.12.

@verult Please link to design doc

@saad-ali saad-ali modified the milestones: v1.11, v1.12 Jun 4, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

Thanks for the update, @saad-ali!!

@warmchang

This comment has been minimized.

Copy link

warmchang commented Jun 14, 2018

Both alpha and beta milestone are the 1.12?

image

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jun 30, 2018

@warmchang updated, thanks!

@warmchang

This comment has been minimized.

Copy link

warmchang commented Jun 30, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@verult @vladimirvivien @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jul 19, 2018

@justaugustus yes so far it has mostly been design work, but I've just begun prototyping. Some design aspects might take time to decide but still aiming for 1.12 at this time.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 22, 2018

@verult thanks for the update! We've added it to the tracking sheet.

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Jul 24, 2018

@verult is there a PR yet for this ?

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jul 25, 2018

@vladimirvivien no code PR yet, the design doc PR linked in the description is WIP at the moment as several aspects are under discussion, including CSI registry, label format, and the possibility of leveraging a new TopologyDomains object (part of the capacity reporting proposal).

@zparnold

This comment has been minimized.

Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @verult I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Aug 20, 2018

I will be adding some documentation here: kubernetes/website#9939. We'll need to see what other additional documentation will be needed for the CSI integration.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

@verult @vladimirvivien --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Sep 5, 2018

The PR did not make 1.12 code freeze and we've requested an exception

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@kacole2 kacole2 removed the tracked/yes label Oct 15, 2018

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 15, 2018

/milestone clear

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 13, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 14, 2019

/remove-lifecycle stale

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 16, 2019

@verult @vladimirvivien Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 16, 2019

We plan to move to beta in 1.14. This feature already has a design proposal. Do we need to convert it to a kep?

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 18, 2019

@msau42 yes please convert it to a KEP! Also let me know if there are any outstanding PRs for this issue. Thanks

@claurence claurence added this to the v1.14 milestone Jan 22, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Jan 22, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 30, 2019

kep is here: #742

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 15, 2019

Didn't we already API review this?

If not, I guess it's me. :)

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 15, 2019

Didn't we already API review this?

If not, I guess it's me. :)

if so, should be quick, right? :)

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019

@msau42 msau42 referenced this issue Feb 15, 2019

Open

Pass Pod information in CSI calls #603

0 of 1 task complete
@jaredbhatti

This comment has been minimized.

Copy link

jaredbhatti commented Feb 15, 2019

Hey folks, I'm helping out with the docs for v1.14.

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions or need additional guidance!

@liggitt liggitt removed this from Assigned in API Reviews Feb 20, 2019

@lachie83

This comment has been minimized.

Copy link
Member

lachie83 commented Feb 25, 2019

Hello @msau42, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 25, 2019

These two PRs are pending:

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 28, 2019

docs pr: kubernetes/website#12889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.