Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes CSI topology support #557

Closed
verult opened this issue Apr 12, 2018 · 54 comments · Fixed by #1696
Closed

Kubernetes CSI topology support #557

verult opened this issue Apr 12, 2018 · 54 comments · Fixed by #1696
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@verult
Copy link
Contributor

verult commented Apr 12, 2018

Feature Description

  • One-line feature description (can be used as a release note): Kubernetes CSI topology support
  • Primary contact (assignee): @verult @vladimirvivien
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo): Topology updates to Kubernetes CSI implementation community#2034
  • Link to e2e and/or unit tests:
  • Reviewer(s): @msau42 @saad-ali
  • Approver (likely from SIG/area to which feature belongs): @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.14
    • Stable release target (x.y) 1.16
@jingxu97 jingxu97 added this to the v1.11 milestone Apr 12, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

/assign @verult @vladimirvivien

@justaugustus justaugustus added sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018
@justaugustus
Copy link
Member

justaugustus commented Jun 4, 2018

@mikedanese -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@saad-ali
Copy link
Member

saad-ali commented Jun 4, 2018

This feature did not make it in to 1.11, punting to 1.12.

@verult Please link to design doc

@saad-ali saad-ali modified the milestones: v1.11, v1.12 Jun 4, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 4, 2018
@justaugustus
Copy link
Member

justaugustus commented Jun 4, 2018

Thanks for the update, @saad-ali!!

@warmchang
Copy link

warmchang commented Jun 14, 2018

Both alpha and beta milestone are the 1.12?

image

@verult
Copy link
Contributor Author

verult commented Jun 30, 2018

@warmchang updated, thanks!

@warmchang
Copy link

warmchang commented Jun 30, 2018

@justaugustus
Copy link
Member

justaugustus commented Jul 18, 2018

@verult @vladimirvivien @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@verult
Copy link
Contributor Author

verult commented Jul 19, 2018

@justaugustus yes so far it has mostly been design work, but I've just begun prototyping. Some design aspects might take time to decide but still aiming for 1.12 at this time.

@justaugustus
Copy link
Member

justaugustus commented Jul 22, 2018

@verult thanks for the update! We've added it to the tracking sheet.

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 22, 2018
@vladimirvivien
Copy link
Member

vladimirvivien commented Jul 24, 2018

@verult is there a PR yet for this ?

@verult
Copy link
Contributor Author

verult commented Jul 25, 2018

@vladimirvivien no code PR yet, the design doc PR linked in the description is WIP at the moment as several aspects are under discussion, including CSI registry, label format, and the possibility of leveraging a new TopologyDomains object (part of the capacity reporting proposal).

@zparnold
Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @verult I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@msau42
Copy link
Member

msau42 commented Aug 20, 2018

I will be adding some documentation here: kubernetes/website#9939. We'll need to see what other additional documentation will be needed for the CSI integration.

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

@verult @vladimirvivien --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@msau42
Copy link
Member

msau42 commented Sep 5, 2018

The PR did not make 1.12 code freeze and we've requested an exception

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@mariantalla
Copy link
Contributor

mariantalla commented Jul 11, 2019

Hey @vladimirvivien @verult @thockin @msau42 - I'm an enhancements shadow for 1.16. Are there plans for this feature to graduate alpha/beta/stable stages? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed there was no KEP linked in the issue description; as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

As a reminder; 1.16 milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

@msau42
Copy link
Member

msau42 commented Jul 11, 2019

This is remaining beta in 1.16

@kcmartin
Copy link

kcmartin commented Oct 2, 2019

Hello @msau42, 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

  • PR is merged in
  • In an implementable state
  • Include test plan and graduation criteria
  • All relevant k/k PRs should be listed in this issue

Thank you.

@msau42
Copy link
Member

msau42 commented Oct 2, 2019

HI @kcmartin, we intend to graduate this feature to GA in 1.17. I will be starting on the KEP update shortly.

@msau42
Copy link
Member

msau42 commented Oct 3, 2019

KEP update: #1273

@kcmartin
Copy link

kcmartin commented Oct 3, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 3, 2019
@kcmartin kcmartin added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 3, 2019
@msau42
Copy link
Member

msau42 commented Oct 3, 2019

/assign

@msau42
Copy link
Member

msau42 commented Oct 3, 2019

API + feature gate PR: kubernetes/kubernetes#83474
Other misc CSI sidecar work tracked in: https://github.com/orgs/kubernetes-csi/projects/19

@kcmartin
Copy link

kcmartin commented Oct 9, 2019

Hi @msau42 -- We're only 5 days away from the Enhancements Freeze (Tuesday, October 15, EOD PST). Another friendly reminder that to be able to graduate this in the 1.17 release, KEP must have graduation criteria defined, in an implementable state, and merged in.

@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

Hello @msau42 I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@irvifa
Copy link
Member

irvifa commented Nov 1, 2019

@msau42

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

@msau42
Copy link
Member

msau42 commented Nov 4, 2019

Docs PR: kubernetes/website#17408

@kcmartin
Copy link

kcmartin commented Nov 6, 2019

Hi @msau42
I am one of the Enhancements Shadows for the 1.17 Release Team. We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that  kubernetes/kubernetes#83474 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

@msau42
Copy link
Member

msau42 commented Dec 6, 2019

All the work to make the feature GA in 1.17 is done.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

@msau42: Closing this issue.

In response to this:

All the work to make the feature GA in 1.17 is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 16, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

Hi @msau42, since this enhancement graduated in 1.17, can you please mark the KEP as implemented? 🙂

@palnabarun
Copy link
Member

palnabarun commented Apr 16, 2020

/reopen

(reopening this issue in the interim)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2020

@palnabarun: Reopened this issue.

In response to this:

/reopen

(reopening this issue in the interim)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.