Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar containers KEP #3761

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Sidecar containers KEP #3761

merged 3 commits into from
Feb 9, 2023

Conversation

SergeyKanzhelev
Copy link
Member

/sig node
/cc @matthyx @jpbetz
/cc @derekwaynecarr @thockin @mrunalp

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2023
matthyx
matthyx approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise SGTM

@matthyx
Copy link
Contributor

matthyx commented Jan 20, 2023

Thank you @SergeyKanzhelev and @jpbetz !

tzneal
tzneal reviewed Jan 20, 2023
View reviewed changes
keps/sig-node/3759-kep-template/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-kep-template/README.md Outdated Show resolved Hide resolved
swatisehgal
swatisehgal reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focused on the resource management part of the proposal, will take a look at the overall proposal if time allows in the coming days.

keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
thockin
thockin reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, YAY! Happy to see this proceed.

keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
keps/sig-node/3759-sidecar-containers/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, matthyx, mrunalp, SergeyKanzhelev, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Feb 9, 2023
@SergeyKanzhelev SergeyKanzhelev added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 9, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Feb 9, 2023

/hold cancel

Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Feb 9, 2023

Given a bunch of approvals above, let me actually go ahead and lgtm it too.

Let's make this happen - this is really cool!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0dc6db7 into kubernetes:master Feb 9, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 9, 2023
@pacoxu pacoxu mentioned this pull request Feb 17, 2023
Open
@BenTheElder BenTheElder mentioned this pull request Mar 19, 2023
Closed
smarterclayton
smarterclayton reviewed Apr 14, 2023
View reviewed changes
keps/sig-node/753-sidecar-containers/README.md
This alternative is trying to replicate systemd dependencies. The alternative
was rejected for the following reasons:
- Universal sidecars injection is not possible for such a system.
- There were lack of scenarios requiring more than general containers sequencing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to gather more scenarios - if people hear about them, please send them my way (I may create a separate tracking issue)

@danehans danehans mentioned this pull request Apr 25, 2023
Closed
@songjiaxun songjiaxun mentioned this pull request May 4, 2023
Closed
@andreyvelich andreyvelich mentioned this pull request Jul 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@tzneal tzneal tzneal left review comments

@rata rata rata left review comments

@jpbetz jpbetz jpbetz left review comments

@howardjohn howardjohn howardjohn left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@thockin thockin thockin left review comments

@evankanderson evankanderson evankanderson left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@vinaykul vinaykul vinaykul left review comments

@swatisehgal swatisehgal swatisehgal left review comments

@gjkim42 gjkim42 gjkim42 left review comments

@matthyx matthyx matthyx approved these changes

@sftim sftim sftim left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@howardjohn howardjohn

@dchen1107 dchen1107

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet