-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3751: Kubernetes VolumeAttributesClass ModifyVolume #3780
Conversation
e13320a
to
14e466e
Compare
type: Container | ||
``` | ||
|
||
QoS should have similar issues to resize (except that we have to solve reducing IO). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some description about how current QoS setting in StorageClass parameters will affect namespace quota. Will it get copied (how?) from SCs to PVCs? Will this KEP disallow mixing QoS in StorageClass and in PVCs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the release note - admission_control_resource_quota.md, it is not so clear to me what is the existing behavior. But I think for the QoS feature, it is risky to trigger an update to force the params within the ResourceQuota etc. Maybe we should design it in a way that does not reduce and only increase Iops/throughput in this situation.
14e466e
to
c865bd0
Compare
Please add a file with PRR approver like this: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3107.yaml |
585fe9d
to
a47c531
Compare
c1c48f4
to
6fbd020
Compare
6fbd020
to
a24195a
Compare
Will let @xing-yang give final lgtm |
5863904
to
8929cf6
Compare
/lgtm |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, msau42, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sunnylovestiramisu What is the difference of VolumeAttributesClass and StorageClass? |
|
If I misunderstood your question and the KEP, please correct me. Thanks! |
@carlory
|
If you're interested in the implementation of the feature, you can find it in the github project. And we encourage some people to join us to implement the feature. |
Hello, when I click on the link, I have a 404 error page. Sorry I am quite new to Kubernetes and opensource project. |
@PrasanaaV Since you are not a member of kubernetes-csi, you cannot see the board, if you want to apply for membership you can go through the application process. However you can still see the open issues in k/k issues page related to this kep by searching "KEP-3751". You should be able to see those unassigned tasks. |
latest-milestone: "1.28" | ||
|
||
# The milestone at which this feature was, or is targeted to be, at each stage. | ||
milestone: | ||
alpha: "v1.28" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 1.32, right? Would someone update this to match with a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/sig storage