Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kube-state-metrics staging repo #384

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

brancz
Copy link
Member

@brancz brancz commented Sep 30, 2019

This adds a kube-state-metrics staging repo so we can stop using external registries and/or have to ping people working at google to publish images.

I'm not entirely sure I've done everything correctly, but I believe I followed these steps: https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io#staging-repos

Let me know if this is everything that is needed. 🙂

cc @cblecker @nikhita @lilic @tariq1890

@k8s-ci-robot
Copy link
Contributor

Welcome @brancz!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/k8s-infra labels Sep 30, 2019
@tariq1890
Copy link
Contributor

If I understand correctly, we use two registry repos then? Staging and Production?

@nikhita
Copy link
Member

nikhita commented Sep 30, 2019

If I understand correctly, we use two registry repos then? Staging and Production?

Eventually, yes.

Right now the tool used to promote images is WIP so we just use the staging repo. When it is ready, we can start having prod ones too.

groups/groups.yaml Outdated Show resolved Hide resolved
@brancz
Copy link
Member Author

brancz commented Oct 1, 2019

I believe all comments are resolved. Please take a look. 🙂

Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me :)

@nikhita
Copy link
Member

nikhita commented Oct 16, 2019

@dims @thockin ping :)

@nikhita
Copy link
Member

nikhita commented Oct 16, 2019

I'm realllyyyyyy sorry about the back and forth dance on this, but while working on #399, I realized that using kube-state-metrics would be fine since we'll need to count the character length with the k8s-staging- prefix, not k8s-infra-staging- prefix. 🙈

k8s-staging-kube-state-metrics is exactly 30 characters (and that's the maximum value allowed).

  • k8s-staging- prefix is used in the manifest file, which is the one gcloud complains about.
  • k8s-infra-staging- prefix is used for google groups, and google groups doesn't complain about the character length.

@brancz
Copy link
Member Author

brancz commented Oct 16, 2019

Got it. Will update this in a bit then!

@brancz
Copy link
Member Author

brancz commented Oct 16, 2019

Done.

@dims dims removed their request for review October 16, 2019 13:54
@tariq1890
Copy link
Contributor

Thanks @nikhita !

One of the owners just removed their request for review :(.
/assign @cblecker

@@ -56,6 +56,7 @@ STAGING_PROJECTS=(
multitenancy
publishing-bot
release-test
kube-state-metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brancz I think you need to maintain lexical order here. As stated in the comment above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dims
Copy link
Member

dims commented Oct 22, 2019

Apologies! i was cleaning my PR queue and lost this one.

@brancz please fix the lexical order as @tariq1890 mentions and ping me on slack and i'll get this in.

/assign

@brancz
Copy link
Member Author

brancz commented Oct 22, 2019

Done! Thanks! Let me know if there is anything else 🙂 .

@dims
Copy link
Member

dims commented Oct 22, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit e54caf8 into kubernetes:master Oct 22, 2019
@brancz brancz deleted the kube-state-metrics branch October 22, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants