-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kube-state-metrics staging repo #384
Conversation
Welcome @brancz! |
If I understand correctly, we use two registry repos then? Staging and Production? |
Eventually, yes. Right now the tool used to promote images is WIP so we just use the staging repo. When it is ready, we can start having prod ones too. |
640240d
to
5cd0331
Compare
5cd0331
to
f514c0e
Compare
f514c0e
to
f311894
Compare
I believe all comments are resolved. Please take a look. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm to me :)
I'm realllyyyyyy sorry about the back and forth dance on this, but while working on #399, I realized that using
|
Got it. Will update this in a bit then! |
f311894
to
cd874a4
Compare
Done. |
infra/gcp/ensure-staging-storage.sh
Outdated
@@ -56,6 +56,7 @@ STAGING_PROJECTS=( | |||
multitenancy | |||
publishing-bot | |||
release-test | |||
kube-state-metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brancz I think you need to maintain lexical order here. As stated in the comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Apologies! i was cleaning my PR queue and lost this one. @brancz please fix the lexical order as @tariq1890 mentions and ping me on slack and i'll get this in. /assign |
cd874a4
to
9470d33
Compare
Done! Thanks! Let me know if there is anything else 🙂 . |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a kube-state-metrics staging repo so we can stop using external registries and/or have to ping people working at google to publish images.
I'm not entirely sure I've done everything correctly, but I believe I followed these steps: https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io#staging-repos
Let me know if this is everything that is needed. 🙂
cc @cblecker @nikhita @lilic @tariq1890