Create a GCS bucket for CNI artifacts #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@dcbw to recommend other owners for this role |
justaugustus
suggested changes
Jan 28, 2020
groups/groups.yaml
Outdated
| settings: | ||
| ReconcileMembers: "true" | ||
| members: | ||
| - saugustus@vmware.com |
There was a problem hiding this comment.
Suggested change
| - saugustus@vmware.com | |
| - stephen.k8s@agst.us |
New group Minor refactoring of GCP infra (needs more) New GCS bucket
|
Fixed
…On Tue, Jan 28, 2020 at 10:40 AM Stephen Augustus ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Just a fix on my email address; everything else looks good!
------------------------------
In groups/groups.yaml
<#553 (comment)>:
> @@ -287,6 +287,17 @@ groups:
- ***@***.***
- ***@***.***
+ - email-id: ***@***.***
+ name: k8s-infra-push-cni
+ description: |-
+ ACL for pushing CNI artifacts
+ settings:
+ ReconcileMembers: "true"
+ members:
+ - ***@***.***
⬇️ Suggested change
- - ***@***.***
+ - ***@***.***
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#553?email_source=notifications&email_token=ABKWAVAUJLV5CKONHRX4HMLRAB3ZFA5CNFSM4KMWNM62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTLJWLQ#pullrequestreview-349608750>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVB3SCLWGBP7KWN5LATRAB3ZFANCNFSM4KMWNM6Q>
.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Open
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New group
Minor refactoring of GCP infra (needs more)
New GCS bucket