-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question. How to enable custom metrics. #1467
Comments
This needs us to map a flag (--enable-custom-metrics I believe). I'll mark it as such and circle back and add the requested flags en-masse. |
Thank you @justinsb. |
Hey @justinsb, now with 1.5.1 released, how can one enable custom metrics? It seems there is no documentation whatsoever. I tried to set enableCustomMetrics to true in cluster configuration but it gets erased, same for nodes ig. Thanks! |
@justinsb I'm also needing to understand how to use this new flag? is it something along the lines of |
Any news on that? Lots of things changed in 1.6 regarding custom metrics but still, docs on this topic are fuzzy at best. |
This continues in #2652 |
This is an API value that needs to be added to the kubelet section. The new yaml docs that were added should help. Here is the PR that was added for the flag. This doc talks about using and editing the yaml API of a cluster https://github.com/kubernetes/kops/blob/master/docs/manifests_and_customizing_via_api.md |
@kwinczek this is probably a late answer to your question but an answer nonetheless. You need something like this in your cluster spec ... spec:
kubelet:
enableCustomMetrics: true
resolvConf: "/etc/resolv.conf" This was enabled/added in db54ecf. The reason you need
If you don't set it, you won't be able to save the change as kops will complain of invalid value (or something like that ... don't quite remember what the error was). By, "Where the corresponding configuration value can be empty" ... they mean this part of the cluster component. Update: This is the error I was talking about earlier ...
|
I am getting the same error on adding it to my cluster spec in both the ways.
|
Any updates on this? |
@moos3 I got it working using
and then
But not able to get autoscaling based on QPS working. |
Awesome, trying now. |
Re-opening. Does someone mind documenting once we figure this out? |
@chrislovecnm I don't mind doing it ... I can give this a stab this week and report back. |
@chrislovecnm @itskingori I can document it can you point me where to document that ? I will create a PR. Thanks. |
@RahulMahale https://github.com/kubernetes/kops/blob/master/docs/cluster_spec.md is probably best :) |
Thank @chrislovecnm here we go #3570 |
@RahulMahale awesome! Keen to give it a spin. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This is safe to close. Added horizontal_pod_autoscaling.md in #3942 which explains the how. If not clear, lemme know and I can clarify/assist. |
How to use |
@alrf I think you might have been confused by #1467 (comment). There's no So if you set this ... spec:
kubelet:
enableCustomMetrics: true ... in your kops cluster state, the flag will be set where it needs to be set. |
does this command deprecated? |
It seems yes 52564 |
I am trying to use custom metrics to scale our cluster upon.
Came across this document which describes how to achieve that.
https://github.com/mwielgus/kubernetes.github.io/blob/custom-metrics/docs/user-guide/horizontal-pod-autoscaling/index.md#support-for-custom-metrics
My question is how how to start/edit cluster with
ENABLE_CUSTOM_METRICS
variable set totrue
.The text was updated successfully, but these errors were encountered: