Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-iam-authenticator v0.5.1 backend-mode(s) #9468

Closed
fred-vogt opened this issue Jul 1, 2020 · 4 comments
Closed

aws-iam-authenticator v0.5.1 backend-mode(s) #9468

fred-vogt opened this issue Jul 1, 2020 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@fred-vogt
Copy link

fred-vogt commented Jul 1, 2020

Would like to get this one in before the first office hours in July 2020.

1. Describe IN DETAIL the feature/behavior/change you would like to see.
Support for backend-modes that don't require restarting the containers running on masters when mappings are updated.

Currently kops deploys aws-iam-authenticator with a volume mounted ConfigMap - this is the mounted-file backend-mode.

@rifelpet - I think you were going to add a clusterspec.authentication.aws.backendMode setting already.

2. Feel free to provide a design supporting your feature request.

  authentication:
    aws:
      backendMode: CRD,EKSConfigMap,MountedFile

BTW - Tested with latest release - Its safe to use as new default image

  authentication:
    aws: 
      image: 602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon/aws-iam-authenticator:v0.5.1-stretch

Docs

Links

@rifelpet
Copy link
Member

rifelpet commented Jul 1, 2020

I agree this would be great to have, thanks for outlining this!

Theres a WIP PR already for updating the image: #8991 and we can probably do the API changes in a separate PR.

marking this as good first issue because the api change is pretty straight forward. the development docs have a good walkthrough on how to do this if anyone is interested in taking it on.

@rifelpet rifelpet added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 1, 2020
@fred-vogt
Copy link
Author

@rifelpet - I over hauled my test setup to provide "full" support for running custom kops builds.

I think I can provide an implementation PR for this early next week.
I'll need to do some testing / thinking about the various modes.

@rifelpet
Copy link
Member

rifelpet commented Aug 9, 2020

This has been implemented as linked above and will be in Kops 1.19.0

/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closing this issue.

In response to this:

This has been implemented as linked above ^

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants