Fix cluster validation dependency on local kubeconfig #10221
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @olemarkus |
|
Don't know why travis fails, it works fine locally. Is there a way to retrigger the job ? |
|
I wonder if we want to pass the whole config or just the Host. |
|
@johngmyers i wondered about that too. Maybe you’re right, passing only the Host will be simpler. Thanks, I ’ll change that. |
|
/test pull-kops-e2e-kubernetes-aws |
| @@ -133,9 +126,7 @@ func (v *clusterValidatorImpl) Validate() (*ValidationCluster, error) { | |||
|
|
|||
| // Do not use if we are running gossip | |||
| if !dns.IsGossipHostname(clusterName) { | |||
There was a problem hiding this comment.
Not sure if we should use host instead of clusterName here ?
There was a problem hiding this comment.
If we are using gossip, won't host be the load balancer DNS?
There was a problem hiding this comment.
You’re probably right, I don’t much about gossip mode.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddycharly, johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR fixes cluster validation dependency on a local kubeconfig file.
Cluster validation requires a local kubeconfig file with a context having the same name as the cluster.
This PR replaces this requirement by providing a
rest.Config, the same that was used to build thek8sclientused to communicate with the target cluster.