Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename duplicate ci target to quick-ci #10378

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 7, 2020

This will avoid some make warnings.

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 7, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@hakman
Copy link
Member Author

hakman commented Dec 7, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@hakman hakman changed the title Rename duplicate ci target to dev-ci Rename duplicate ci target to quick-ci Dec 7, 2020
@hakman
Copy link
Member Author

hakman commented Dec 7, 2020

Small mistake in how this should be handled, but fixed now.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@hakman
Copy link
Member Author

hakman commented Dec 7, 2020

Thanks @olemarkus

@k8s-ci-robot k8s-ci-robot merged commit e2a5695 into kubernetes:master Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 7, 2020
k8s-ci-robot added a commit that referenced this pull request Dec 7, 2020
…10378-upstream-release-1.19

Automated cherry pick of #10366: Remove dependency on TravisCI #10378: Rename duplicate ci target to quick-ci
k8s-ci-robot added a commit that referenced this pull request Dec 8, 2020
…10378-upstream-release-1.18

Automated cherry pick of #10366: Remove dependency on TravisCI #10378: Rename duplicate ci target to quick-ci
@hakman hakman deleted the make-dev-ci branch January 10, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants