Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine type generator #5553

Merged
merged 6 commits into from
Sep 14, 2018

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Jul 31, 2018

Instead of updating this manually, I've created a generator for us using the aws pricing api

var MachineTypes []AWSMachineTypeInfo = []AWSMachineTypeInfo{
// This is tedious, but seems simpler than trying to have some logic and then a lot of exceptions
// t2 family
{
Name: "t2.nano",
MemoryGB: 0.5,
ECU: 3 * BurstableCreditsToECUS,
Cores: 1,
EphemeralDisks: nil,
Burstable: true,
},
{
Name: "t2.micro",
MemoryGB: 1,
ECU: 6 * BurstableCreditsToECUS,
Cores: 1,
EphemeralDisks: nil,
Burstable: true,
},

I had spot checked a few of our machine types and they're not all correct so I figured this would be a better medium term solution.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2018
@mikesplain
Copy link
Contributor Author

I'd like to add a quick readme and docs update.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2018
@mikesplain mikesplain force-pushed the machine_type_generator branch 4 times, most recently from 7d7112c to 6418777 Compare July 31, 2018 12:57
@mikesplain
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2018
@mikesplain mikesplain force-pushed the machine_type_generator branch 2 times, most recently from 9b9043b to 43f93c4 Compare July 31, 2018 13:36
@mikesplain
Copy link
Contributor Author

/assign @justinsb

@mikesplain
Copy link
Contributor Author

I have a better way to do this.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@mikesplain mikesplain force-pushed the machine_type_generator branch 5 times, most recently from 81292a1 to a5bf19c Compare August 16, 2018 19:07
@mikesplain
Copy link
Contributor Author

Alrighty this should be set now. Less deps and faster than before too!

/cc @justinsb

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2018
@mikesplain
Copy link
Contributor Author

/retest

@justinsb
Copy link
Member

I have a follow-up that sets some fields that we weren't using, but that I needed to do to verify the output sanely :-)

But the fields we care about match, or our values did not match what AWS (now) documents, so lgtm - thanks @mikesplain

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member

Follow up is in #5783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants