-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine type generator #5553
Machine type generator #5553
Conversation
I'd like to add a quick readme and docs update. /hold |
7d7112c
to
6418777
Compare
/hold cancel |
9b9043b
to
43f93c4
Compare
/assign @justinsb |
I have a better way to do this. /hold |
81292a1
to
a5bf19c
Compare
Alrighty this should be set now. Less deps and faster than before too! /cc @justinsb /hold cancel |
a5bf19c
to
c427df6
Compare
/retest |
c427df6
to
29e852a
Compare
I have a follow-up that sets some fields that we weren't using, but that I needed to do to verify the output sanely :-) But the fields we care about match, or our values did not match what AWS (now) documents, so lgtm - thanks @mikesplain /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up is in #5783 |
Instead of updating this manually, I've created a generator for us using the aws pricing api
kops/upup/pkg/fi/cloudup/awsup/machine_types.go
Lines 74 to 93 in cfaf0b7
I had spot checked a few of our machine types and they're not all correct so I figured this would be a better medium term solution.