Tweak machine_types generator to match our existing values #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Merged
|
/assign @mikesplain |
|
Oh yeah great additions @justinsb! Thanks so much! /lgtm |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added
the
lgtm
|
/test pull-kops-e2e-kubernetes-aws |
k8s-ci-robot
added
the
needs-rebase
For whatever reason it wasn't working for me...
justinsb
force-pushed
the
machine_type_generator_2
branch
from
2911c43
to
2a2b873
Compare
k8s-ci-robot
added
size/XS
|
Not a lot left in this PR now, but fixes the error message! |
|
Thanks @justinsb /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't outputing the Burstable or GPU attributes, and the
sorting order wasn't quite the same. This made verification harder.
(Please don't merge until after #5553 has merged, and I will rebase if needed)