Honor documentation regarding state : enable file state store #6463

[Seb-Solon]

As the doc mention file state are supported : https://github.com/kubernetes/kops/blob/master/docs/state.md

Unfortunately this false boolean in the vfs.go file won't allow this. Simply changing this value seems to make it work

Test made

TEMP_DIR=$(mktemp -d)
cd $TEMP_DIR
# $KOPS_BUILD_PATH is the path for building kops. (ending with  .build/local)
# Build is made by running "make kops" at the root of this repo , go version go1.12.7 linux/amd64
# I have nothing in us-east-1a it was jsut to launch the command line
$KOPS_BUILD_PATH/kops create cluster --name test.k8s.local --state=$TEMP_DIR/state --zones us-east-1a
# I interrupt the process when it is trying to contact AWS API 
# Message like : No progress made, sleeping before retrying 2 failed task(s)

$KOPS_BUILD_PATH/kops create secret dockerconfig -f ~/.docker/config.json --name test.k8s.local --state=$TEMP_DIR/state
$KOPS_BUILD_PATH/kops create secret sshpublickey admin -i ~/.ssh/id_rsa.pub --name test.k8s.local --state=$TEMP_DIR/state

ls -l $TEMP_DIR/state/test.k8s.local 
total 24
-rw------- 1 user user 5103 Jul 22 15:47 cluster.spec
-rw------- 1 user user 1068 Jul 22 15:47 config
drwxr-xr-x 2 user user 4096 Jul 22 15:47 instancegroup
drwxr-xr-x 3 user user 4096 Jul 22 15:47 pki
drwxr-xr-x 2 user user 4096 Jul 22 15:47 secrets

cd /tmp
rm -rf $TEMP_DIR

The state is written into the expected directory as shown.

Let me know if you need anything else to validate this but that look like a very trivial fix.

[k8s-ci-robot]

Welcome @Seb-Solon!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @Seb-Solon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Seb-Solon
To complete the pull request process, please assign andrewsykim
You can assign the PR to them by writing /assign @andrewsykim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Seb-Solon]

Cla should get green now

[k8s-ci-robot]

@Seb-Solon: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Seb-Solon]

/assign @andrewsykim

[Seb-Solon]

Actually it looks like it's mostly a duplicate from #6465 . The support of such local state file is hard to define apparently as a local file can't be accessed by the cluster during creation.

The documentation update made by the other PR seems enough, I am not sure what's missing to merge it.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.