Skip to content

Resources leak fix #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

Resources leak fix #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/validation/spec/ref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func (r *Ref) IsValidURI(basepaths ...string) bool {
if err != nil {
return false
}
defer rr.Body.Close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR... IsValidURI is actually completely unused, and we actively don't want to be making http calls from validation in this module.

If you want to delete this method entirely, that would be ideal.

(you'll also need to sign the cncf cla to pass the bot check for merge)


return rr.StatusCode/100 == 2
}
Expand Down