Skip to content

Add client-go in the accessing cluster doc #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2016
Merged

Add client-go in the accessing cluster doc #1127

merged 1 commit into from
Sep 15, 2016

Conversation

caesarxuchao
Copy link
Contributor

@caesarxuchao caesarxuchao commented Aug 30, 2016 •
edited
Loading

ref: kubernetes/kubernetes#31751

This change is Reviewable

lavalamp
lavalamp reviewed Aug 30, 2016
View reviewed changes
docs/user-guide/accessing-the-cluster.md

To use it,
* Run `go get k8s.io/client-go/1.4/kubernetes` to get the library. 1.4 is a release version of your choice.
* Write application atop of the client-go clients. Note that client-go defines its own API objects, so if needed, please import API definitions from client-go rather than from the main repository, e.g., `import "k8s.io/client-go/1.4/pkg/api"` is correct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 ;)

@lavalamp
Copy link
Contributor

looks great as soon as we get the example files in.

@caesarxuchao caesarxuchao mentioned this pull request Aug 30, 2016
Merged
@nikhiljindal
Copy link
Contributor

Did you want to send this PR to release-1.4 branch?

@caesarxuchao
Copy link
Contributor Author

Yes, we want to. Do you know what milestone to apply? launchday?

@devin-donnelly devin-donnelly added this to the 1.4 milestone Aug 31, 2016
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Sep 1, 2016
Merge pull request #31751 from caesarxuchao/client-go-examples
8afd3c3 
Automatic merge from submit-queue

Add client-go examples

We'll wait for the publish bot to published this to kubernetes/client-go

cc @devin-donnelly

ref: kubernetes/website#1127
@caesarxuchao
Copy link
Contributor Author

@lavalamp can I get the LGTM? Thanks.

@lavalamp
Copy link
Contributor

lavalamp commented Sep 7, 2016

@devin-donnelly Is this OK to merge in the master branch or should it go to the 1.4 branch?

@caesarxuchao
Copy link
Contributor Author

I think merging in master is ok, there is nothing specific to 1.4 here.

@devin-donnelly
Copy link
Contributor

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

docs/user-guide/accessing-the-cluster.md, line 106 [r2] (raw file):

To use it, 
* Run `go get k8s.io/client-go/1.4/kubernetes` to get the library. 1.4 is a release version of your choice.

I would mention that 1.4 is the latest version, and tell them what the minimum supported version is.

docs/user-guide/accessing-the-cluster.md, line 107 [r2] (raw file):

To use it, 
* Run `go get k8s.io/client-go/1.4/kubernetes` to get the library. 1.4 is a release version of your choice.
* Write application atop of the client-go clients. Note that client-go defines its own API objects, so if needed, please import API definitions from client-go rather than from the main repository, e.g., `import "k8s.io/client-go/1.4/pkg/api/v1"` is correct.

Write application -> Write an application

Comments from Reviewable

@devin-donnelly
Copy link
Contributor

docs/user-guide/accessing-the-cluster.md, line 107 [r1] (raw file):

Previously, lavalamp (Daniel Smith) wrote…

v1 ;)

Right, but we don't want the user to have to guess what exact number to type in. 1.4 works, so I assume it's also 1.0, 1.1, 1.2, 1.3, etc.

Comments from Reviewable

@caesarxuchao
Copy link
Contributor Author

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

docs/user-guide/accessing-the-cluster.md, line 106 [r2] (raw file):

Previously, devin-donnelly wrote…

I would mention that 1.4 is the latest version, and tell them what the minimum supported version is.

How about "1.4 is a release version of your choice. Visit https://github.com/kubernetes/client-go to see what versions are supported"?

Comments from Reviewable

@caesarxuchao
Copy link
Contributor Author

@devin-donnelly PTAL. Thanks.

@devin-donnelly
Copy link
Contributor

docs/user-guide/accessing-the-cluster.md, line 106 at r2 (raw file):

Previously, caesarxuchao (Chao Xu) wrote…

How about "1.4 is a release version of your choice. Visit https://github.com/kubernetes/client-go to see what versions are supported"?

I would change to:

"To get the library, run the following command: go get k8s.io/client-go/<version number>/kubernetes See https://github.com/kubernetes/client-go to see which versions are supported."

Comments from Reviewable

@devin-donnelly
Copy link
Contributor

@caesarxuchao One suggested revision.

@caesarxuchao
Copy link
Contributor Author

@devin-donnelly thanks for the edits. PTAL. Thanks.

@devin-donnelly devin-donnelly merged commit 946fe49 into kubernetes:master Sep 15, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
@C-Mejlak @alpeb @cpretzer
update: june meetup (kubernetes#1127)
f97bea0 
* update: june meetup

- add video schema
- add featured image

Signed-off-by: Christian Mejlak <chris@mejlak.com>

* Update Contour instructions (kubernetes#1123)

Fixes linkerd/linkerd2#6237

- Since a few releases ago, `linkerd inject` will fail outright if
`automountServiceAccountToken` is not `true`. Reshuffled the instructions to
account for that.
- Added note about adding the
`config.linkerd.io/skip-outbound-ports: 8001` annotation when in ingress mode.
- Removed the `spec.routes.services.namespace` field from the sample
`HTTPProxy` resource, which doesn't appear in the resource API doc.
- Replaced `127.0.0.1.xip.io` with `127.0.0.1.nip.io` as the former is down.

Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>

* update: june meetup

- add video schema
- add featured image

Signed-off-by: Christian Mejlak <chris@mejlak.com>

Co-authored-by: Alejandro Pedraza <alejandro@buoyant.io>
Co-authored-by: cpretzer <cpretzer@users.noreply.github.com>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
@seokho-son
Merge pull request kubernetes#1127 from cncf/main
652da1b 
Update dev-ko branch with main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@devin-donnelly devin-donnelly

Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@caesarxuchao @lavalamp @nikhiljindal @devin-donnelly @googlebot