Skip to content

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 26, 2017

For 1.6 only

Builds on #2169


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2017
@liggitt liggitt force-pushed the rbac-user-guide branch 3 times, most recently from c02c29d to 1d14da9 Compare January 26, 2017 18:16
@jaredbhatti
Copy link
Contributor

Marking this "Do not merge" since it relates to 1.6

@jaredbhatti jaredbhatti added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 26, 2017
@liggitt
Copy link
Member Author

liggitt commented Jan 26, 2017

@jaredbhatti any timeframe for the 1.6 branch? pointing people to PR previews is suboptimal

@chenopis
Copy link
Contributor

@liggitt FYI, the kubernetes:release-1.6 branch is now available. Please change the base branch to that. Thx

@liggitt liggitt changed the base branch from master to release-1.6 February 14, 2017 17:13
@chenopis chenopis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 14, 2017
@liggitt liggitt force-pushed the rbac-user-guide branch 2 times, most recently from 47d4acc to 7814278 Compare February 14, 2017 22:16
section:
- docs/admin/accessing-the-api.md
- docs/admin/authentication.md
- docs/admin/authorization.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenopis can you verify this is a good way to group a set of documents around authorization? the main topic is becoming huge, and I think we'll eventually want a page dedicated to each authz plugin. I think doing it this way preserves links to the old page (the old page is the index of the directory named identically to the old page)

Copy link
Contributor

@chenopis chenopis Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt Yes, I definitely agree you should breakout each authz plugin into its own page. My suggestions would be

  1. Rename the title of the section to just "Authorization Plugins" so that "Using Authorization Plugins" isn't nested redundantly.
  2. Add a "What's next" section to the bottom of index.md to point the readers to the additional documentation for each plugin.

@liggitt
Copy link
Member Author

liggitt commented Feb 17, 2017

ok, updated the section title. I'll have a lot of follow up PRs to split the other pages out, hoist common information to the overview page, and expand the RBAC page, but I'd like to go ahead and get this merged to get the content on the preview site

@deads2k
Copy link
Contributor

deads2k commented Feb 17, 2017

lgtm

@chenopis
Copy link
Contributor

@liggitt Ok, sounds good.

@chenopis chenopis merged commit 6e9fc80 into kubernetes:release-1.6 Feb 17, 2017
@liggitt
Copy link
Member Author

liggitt commented Feb 18, 2017

thanks. @chenopis @jaredbhatti, do you know how often http://kubernetes-io-vnext-staging.netlify.com/docs/admin/authorization/ gets updated from the release-1.6 branch?

@chenopis
Copy link
Contributor

chenopis commented Feb 21, 2017

@liggitt I'm not sure, but @devin-donnelly would know.

@liggitt
Copy link
Member Author

liggitt commented Feb 21, 2017

@liggitt I believe vnext staging gets updated whenever there's a new merge to release-1.6, but @devin-donnelly would know for sure.

@chenopis @devin-donnelly doesn't appear to, this merged and http://kubernetes-io-vnext-staging.netlify.com/docs/admin/authorization/ was not updated

@chenopis
Copy link
Contributor

@liggitt I asked @devin-donnelly in the SIG Docs meeting just now, and the vnext preview should get setup today for 1.6. There was a config setting that hadn't gotten updated yet.

Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Follow the latest commit in main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants