-
Notifications
You must be signed in to change notification settings - Fork 15k
Updated RBAC doc #2360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RBAC doc #2360
Conversation
c39145a
to
777b0e0
Compare
c02c29d
to
1d14da9
Compare
Marking this "Do not merge" since it relates to 1.6 |
@jaredbhatti any timeframe for the 1.6 branch? pointing people to PR previews is suboptimal |
@liggitt FYI, the kubernetes:release-1.6 branch is now available. Please change the base branch to that. Thx |
47d4acc
to
7814278
Compare
section: | ||
- docs/admin/accessing-the-api.md | ||
- docs/admin/authentication.md | ||
- docs/admin/authorization.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenopis can you verify this is a good way to group a set of documents around authorization? the main topic is becoming huge, and I think we'll eventually want a page dedicated to each authz plugin. I think doing it this way preserves links to the old page (the old page is the index of the directory named identically to the old page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liggitt Yes, I definitely agree you should breakout each authz plugin into its own page. My suggestions would be
- Rename the title of the section to just "Authorization Plugins" so that "Using Authorization Plugins" isn't nested redundantly.
- Add a "What's next" section to the bottom of index.md to point the readers to the additional documentation for each plugin.
7814278
to
28dd868
Compare
ok, updated the section title. I'll have a lot of follow up PRs to split the other pages out, hoist common information to the overview page, and expand the RBAC page, but I'd like to go ahead and get this merged to get the content on the preview site |
lgtm |
@liggitt Ok, sounds good. |
thanks. @chenopis @jaredbhatti, do you know how often http://kubernetes-io-vnext-staging.netlify.com/docs/admin/authorization/ gets updated from the release-1.6 branch? |
@liggitt I'm not sure, but @devin-donnelly would know. |
@chenopis @devin-donnelly doesn't appear to, this merged and http://kubernetes-io-vnext-staging.netlify.com/docs/admin/authorization/ was not updated |
@liggitt I asked @devin-donnelly in the SIG Docs meeting just now, and the vnext preview should get setup today for 1.6. There was a config setting that hadn't gotten updated yet. |
Follow the latest commit in main branch
For 1.6 only
Builds on #2169
This change is