mark node phase as deprecated

[mwhooker]

I'm not sure on what the best wording for this should be, but Node Phase is no longer populated, and so the docs should say so.

@Random-Liu on slack/#sig-node told me that they believed node phase was unused.

cc @dawnchen

---

This change is

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[mwhooker]

signed CLA

[googlebot]

CLAs look good, thanks!

[Random-Liu]

I'm sure the NodePhase is not used in the code, but I'm not sure whether we have the plan to deprecate it or not.

@dchen1107 and @bgrant0607 should have more ideas.

[bgrant0607]

@dchen1107 Did we change how/whether node phase is set? That would be a breaking behavioral change for the v1 API.

If we do plan to deprecate it, it would need to be documented in the API first:
https://github.com/kubernetes/kubernetes/blob/master/pkg/api/v1/types.go#L2327

[pwittrock]

@dchen1107 @Random-Liu Any update on this?

[Random-Liu]

@pwittrock I'm not sure whether we really want to deprecate NodePhase, have to confirm with @dchen1107. She will come back from holiday next Monday. :)

[pwittrock]

@dchen1107 Is NodePhase still populated? What should the docs say?

[dchen1107]

We stopped populate / set node phase a while back. This won't be breaking change for v1 API since no one couldn't depend on it at all. But we still should change v1API code first to make such announcement. Let me send a pr changing v1API shortly.

[pwittrock]

@mwhooker This field will be deprecated in kubernetes/kubernetes#30005 for 1.4. Lets merge it when that change is live.

[mwhooker]

neato! thanks

[devin-donnelly]

This docs change is slated for the 1.4 release. We're trying to have all 1.4 docs PRs target the release-1.4 branch. Can you have this PR target release-1.4? A rebase would probably also be a good idea.