-
Notifications
You must be signed in to change notification settings - Fork 15k
resolves #5618 #5824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #5618 #5824
Conversation
@@ -11,8 +11,8 @@ notitle: true | |||
|
|||
The Kubernetes network proxy runs on each node. This | |||
reflects services as defined in the Kubernetes API on each node and can do simple | |||
TCP, UDP stream forwarding or round robin TCP, UDP forwarding across a set of backends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to keep the white space here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this content is from generated source - the PR to add in whitespace here will really need to be in kubernetes/kubernetes, but I'm not entirely sure where. I'll research this further and see where changes need to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heckj !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangpengzhao kubernetes/kubernetes#53671 has been opened to solve upstream issue here
docs/admin/kube-proxy.md
Outdated
TCP, UDP stream forwarding or round robin TCP, UDP forwarding across a set of backends. | ||
Service cluster IPs and ports are currently found through Docker-links-compatible | ||
TCP, UDP stream forwarding or round robin TCP,UDP forwarding across a set of backends. | ||
Service cluster ips and ports are currently found through Docker-links-compatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use lower case ip
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this content is from generated source - like the whitespace request, relevant changes will need to be in kubernetes/kubernetes, but I'm not entirely sure where. I'll research this further and see where changes need to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangpengzhao kubernetes/kubernetes#53671 has been opened to solve upstream issue here
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. clarifying CLI output **What this PR does / why we need it**: backporting documentation changes made to generated CLI documentation so that the source is correct for updates to the documentation and kubernetes website. This is part of what is needed to resolve kubernetes/website#5618 and is updated based on review feedback while fixing that bug at kubernetes/website#5824 **Which issue this PR fixes** needed for full resolution of kubernetes/website#5618, but will not fix it in itself due to generated documentation being stored as a separate process **Special notes for your reviewer**: Feedback on these changes originated from edits in the k8s docs repository and feedback to regenerated markdown to resolve them. ```release-note NONE ```
regenerated kube-proxy documentation from latest 1.7 branch source and
copied across to this repository
This change is