Skip to content

Conversation

heckj
Copy link
Contributor

@heckj heckj commented Oct 10, 2017

regenerated kube-proxy documentation from latest 1.7 branch source and
copied across to this repository


This change is Reviewable

regenerate kube-proxy documentation from latest 1.7 branch source and
copied across to this repository
@heckj heckj requested a review from mengqiy October 10, 2017 01:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2017
@@ -11,8 +11,8 @@ notitle: true

The Kubernetes network proxy runs on each node. This
reflects services as defined in the Kubernetes API on each node and can do simple
TCP, UDP stream forwarding or round robin TCP, UDP forwarding across a set of backends.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to keep the white space here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this content is from generated source - the PR to add in whitespace here will really need to be in kubernetes/kubernetes, but I'm not entirely sure where. I'll research this further and see where changes need to be made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heckj !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangpengzhao kubernetes/kubernetes#53671 has been opened to solve upstream issue here

TCP, UDP stream forwarding or round robin TCP, UDP forwarding across a set of backends.
Service cluster IPs and ports are currently found through Docker-links-compatible
TCP, UDP stream forwarding or round robin TCP,UDP forwarding across a set of backends.
Service cluster ips and ports are currently found through Docker-links-compatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use lower case ip here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this content is from generated source - like the whitespace request, relevant changes will need to be in kubernetes/kubernetes, but I'm not entirely sure where. I'll research this further and see where changes need to be made.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangpengzhao kubernetes/kubernetes#53671 has been opened to solve upstream issue here

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Oct 11, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

clarifying CLI output

**What this PR does / why we need it**:

backporting documentation changes made to generated CLI documentation
so that the source is correct for updates to the documentation and
kubernetes website. This is part of what is needed to resolve
kubernetes/website#5618
and is updated based on review feedback while fixing that bug at
kubernetes/website#5824

**Which issue this PR fixes** 

needed for full resolution of kubernetes/website#5618, but will not fix it in itself due to generated documentation being stored as a separate process

**Special notes for your reviewer**:

Feedback on these changes originated from edits in the k8s docs repository and feedback to regenerated markdown to resolve them. 

```release-note
NONE
```
@steveperry-53 steveperry-53 merged commit 0e0b7a8 into kubernetes:release-1.7 Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants