-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the skip return status support for PreEnqueue, and won't run PreFilter if PreEnqueue returned a Skip status #120237
Comments
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
So generally Skip works for a pair of extension points, like we get |
If you pod is blocked by preEnqueue, the pod will not enter into the activeQ, then blocking in the scheduling cycle. Isn't this as you expected? |
@kerthcet No i want to skip it, don't add it to activeQ, when we skip from preEnqueue. |
I mean right now if your pod is rejected by the PreEnqueue, it will not enter into activeQ, but pending in unschedulablePods. |
@kerthcet If we also can skip unschedulablePods for this case, i am not sure if i make sense right, unschedulablePods will come back to active queue to schedule, we want to skip it totally. |
If the pod failed the PreEnqueue, it will never enter into activeQ, see https://kubernetes.io/blog/2022/12/26/pod-scheduling-readiness-alpha/ for more details please. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Seems we can close this from the previous discussion, any other concerns @zhuqi-lucas |
We can close it @kerthcet , thank you! |
What would you like to be added?
Add the skip return status support for PreEnqueue, and won't run PreFilter if PreEnqueue returned a Skip status
Why is this needed?
We have skip status for PreFilter to return, and when we skip prefilter, the following filter will not run, but we don't have skip choice for PreEnqueue, we'd better add this.
After we support this:
When we skip for the preEnqueue, we can skip add the pod to activeQueue, it's more reasonable and saving time for plugin customer scheduler to optimize.
The text was updated successfully, but these errors were encountered: